Skip to content

fix: correct contentLength check and improve dispose method in extens… #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gorniaky merged 1 commit into from
May 3, 2026
Merged

fix: correct contentLength check and improve dispose method in extens… #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/extensions/io_http_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ extension HttpClientResponseExtension on HttpClientResponse {
bool get ok => statusCode < _badRequestStatusCode;

Future<Uint8List> get bodyBytes async {
if (contentLength case final length when length != -1) {
final bytes = Uint8List(length);
if (contentLength case final length when !length.isNegative) {
int index = 0;
final bytes = Uint8List(length);
await for (final e in this) {
bytes.setAll(index, e);
index += e.length;
Expand Down
12 changes: 6 additions & 6 deletions lib/extensions/list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,27 @@ import "dart:async";
import "package:discloud/cli/disposable.dart";

extension ListDisposableExtension on List<Disposable> {
Future<void> dispose() async {
final futures = <Future>[];
Future<void> dispose() {
final futures = <Future<void>>[];

removeWhere((item) {
if (item.dispose() case final Future future) futures.add(future);
return true;
});

await futures.wait;
return futures.wait;
}
}

extension ListStreamSubscriptionExtension<T> on List<StreamSubscription<T>> {
Future<void> cancel() async {
final futures = <Future>[];
Future<void> cancel() {
final futures = <Future<void>>[];

removeWhere((item) {
futures.add(item.cancel());
return true;
});

await futures.wait;
return futures.wait;
}
}
Loading