feat: validate credential fields on POST /credentials/issue#2
Open
djscruggs wants to merge 2 commits into
Open
feat: validate credential fields on POST /credentials/issue#2djscruggs wants to merge 2 commits into
djscruggs wants to merge 2 commits into
Conversation
Adds field-level validation for @context, type, issuer, and credentialSubject so the mock returns 400 on malformed input, matching the behavior required by the vc-api-issuer-test-suite. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Expand single-line arrow function bodies and split long cast line to satisfy @stylistic/brace-style and @stylistic/max-len rules. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
validateCredentialFieldstoPOST /credentials/issuethat checks@context,type,issuer, andcredentialSubject400 invalid-inputfor missing or malformed required fieldsexpirationDatepass-through checkWhy
The vc-api-issuer-test-suite exercises
POST /credentials/issuewith malformed credentials and expects400responses. Without this validation the mock returned201for all of those cases, making it an unreliable test double for code that depends on correct error behavior.Testing
npm test— all 90 tests passnpx tsc --noEmit— no type errorsReference
tests/10-issuer.js,tests/11-issuer-jwt.js🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com