You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
added --dsc-link-background--active as background on hover as requested in parent issue. Also there was non-functioning code to make the left border of current page blue on hover which i fixed (but not sure if legacy from when there was a line along the full menu).
Should there be a hover on the toc menu as well or no?
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not a fan of the hover on an active item 🤔
Is the same background as for inactive ones not good enough?
Yea as mentioned i 'fixed' some broken css but its probably legacy stuff that was supposed to be removed. Perhaps no hover on current page is better (its not something you are supposed to click on anyway)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4561
added
--dsc-link-background--activeas background on hover as requested in parent issue.Also there was non-functioning code to make the left border of current page blue on hover which i fixed (but not sure if legacy from when there was a line along the full menu).Should there be a hover on the toc menu as well or no?