Skip to content

chore(www): sidebar add hover effect#4564

Merged
oddvernes merged 4 commits intomainfrom
chore/www-sidebar-hover
Mar 6, 2026
Merged

chore(www): sidebar add hover effect#4564
oddvernes merged 4 commits intomainfrom
chore/www-sidebar-hover

Conversation

@oddvernes
Copy link
Copy Markdown
Collaborator

@oddvernes oddvernes commented Mar 3, 2026

resolves #4561

added --dsc-link-background--active as background on hover as requested in parent issue.
Also there was non-functioning code to make the left border of current page blue on hover which i fixed (but not sure if legacy from when there was a line along the full menu).

Should there be a hover on the toc menu as well or no?

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 3, 2026

⚠️ No Changeset found

Latest commit: 7c62d30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

Preview deployments for this pull request:

www - 5. Mar 2026 - 13:15

Copy link
Copy Markdown
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the hover on an active item 🤔

Image

Is the same background as for inactive ones not good enough?

@oddvernes
Copy link
Copy Markdown
Collaborator Author

oddvernes commented Mar 3, 2026

Not a fan of the hover on an active item 🤔
Is the same background as for inactive ones not good enough?

Yea as mentioned i 'fixed' some broken css but its probably legacy stuff that was supposed to be removed. Perhaps no hover on current page is better (its not something you are supposed to click on anyway)

@Barsnes
Copy link
Copy Markdown
Member

Barsnes commented Mar 4, 2026

Should there be a hover on the toc menu as well or no?

I think yes, why not :)

@oddvernes
Copy link
Copy Markdown
Collaborator Author

Added the same hover to toc 👍

@oddvernes oddvernes merged commit edbe2ef into main Mar 6, 2026
7 checks passed
@oddvernes oddvernes deleted the chore/www-sidebar-hover branch March 6, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add visual indicator on hover to our internal links in menus

2 participants