fix(web): support changing tooltip text programmatically#4562
Conversation
🦋 Changeset detectedLatest commit: 6244c84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1bf3f89 to
6348ad7
Compare
Barsnes
left a comment
There was a problem hiding this comment.
Can you add a storybook story for this? Would be great to test it out
Sure! |
|
Hmm I see the text change only after moving the mouse away (so the tooltip goes away) and then back |
I made some minor tweaks to make it CSP friendly and to clear the aria-live-area after announcement so screen readers can not find it by accident Overall; great work @stianmorsund 💯 👏 💪 |
Awesome, thanks for the review 💯 👍 |
Thanks for testing! |
Iframes is in general flaky in regards of reading |
it works fine on windows + chrome + nvda :) |
|
Anyone looking at failing test? 😅 @stianmorsund |
mimarz
left a comment
There was a problem hiding this comment.
This looks ok for me but @Barsnes or @eirikbacker should also take a final look as they know this part of the codebase the best :)
Summary
Support changing tooltip programmatically by updating text of the existing tooltip and announcing change to screen readers. Also made a global announcer and refactored
fieldto use it.Checks
pnpm changesetif relevant)