Skip to content

fix: fix Structure loading with close-duplicate atom#183

Open
stevenhua0320 wants to merge 1 commit intodiffpy:v3.4.0from
stevenhua0320:fix-close-duplicate-atom
Open

fix: fix Structure loading with close-duplicate atom#183
stevenhua0320 wants to merge 1 commit intodiffpy:v3.4.0from
stevenhua0320:fix-close-duplicate-atom

Conversation

@stevenhua0320
Copy link
Contributor

@sbillinge ready to review. This is the potential solution proposed by @Tieqiong last summer diffpy/diffpy.pdfgui#291. We change the order of the source that we trust most as the priority. After this is merged and released, we could ask whether this fix would solve this by asking people to test it.

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (991889b) to head (dc1b007).
⚠️ Report is 5 commits behind head on v3.4.0.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3.4.0     #183      +/-   ##
==========================================
+ Coverage   99.17%   99.19%   +0.01%     
==========================================
  Files          15       15              
  Lines        2439     2489      +50     
==========================================
+ Hits         2419     2469      +50     
  Misses         20       20              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant