fix: fix Structure loading with close-duplicate atom#183
Open
stevenhua0320 wants to merge 1 commit intodiffpy:v3.4.0from
Open
fix: fix Structure loading with close-duplicate atom#183stevenhua0320 wants to merge 1 commit intodiffpy:v3.4.0from
stevenhua0320 wants to merge 1 commit intodiffpy:v3.4.0from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.4.0 #183 +/- ##
==========================================
+ Coverage 99.17% 99.19% +0.01%
==========================================
Files 15 15
Lines 2439 2489 +50
==========================================
+ Hits 2419 2469 +50
Misses 20 20 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review. This is the potential solution proposed by @Tieqiong last summer diffpy/diffpy.pdfgui#291. We change the order of the source that we trust most as the priority. After this is merged and released, we could ask whether this fix would solve this by asking people to test it.