Skip to content

chore: deprecate parseLines method in all parsers#173

Merged
sbillinge merged 1 commit intodiffpy:v3.4.0from
stevenhua0320:deprecate-parser
Mar 3, 2026
Merged

chore: deprecate parseLines method in all parsers#173
sbillinge merged 1 commit intodiffpy:v3.4.0from
stevenhua0320:deprecate-parser

Conversation

@stevenhua0320
Copy link
Contributor

@sbillinge ready to review. Note that because of the inheritance structure, I decide to deprecate the method one by one to avoid any potential break in the code.

@sbillinge sbillinge merged commit 3855f25 into diffpy:v3.4.0 Mar 3, 2026
4 checks passed
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.13%. Comparing base (6286234) to head (0f4ddda).
⚠️ Report is 3 commits behind head on v3.4.0.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.4.0     #173   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          14       14           
  Lines        2301     2315   +14     
=======================================
+ Hits         2281     2295   +14     
  Misses         20       20           
Files with missing lines Coverage Δ
tests/test_p_cif.py 99.65% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants