Make scripts/diff-filter.pl portable to macOS#8839
Merged
tautschnig merged 1 commit intodiffblue:developfrom Mar 4, 2026
Merged
Make scripts/diff-filter.pl portable to macOS#8839tautschnig merged 1 commit intodiffblue:developfrom
tautschnig merged 1 commit intodiffblue:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes a macOS portability issue in the diff-filter.pl script by modifying the sed -i command to work on both GNU and BSD (macOS) sed implementations.
Changes:
- Modified
sed -itosed -i.bakwith explicit backup extension for macOS compatibility - Added cleanup step to remove the temporary backup file after editing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8839 +/- ##
========================================
Coverage 80.00% 80.00%
========================================
Files 1700 1700
Lines 188271 188271
Branches 73 73
========================================
+ Hits 150632 150633 +1
+ Misses 37639 37638 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use Perl file I/O instead of shelling out to sed for line-prefix editing. This avoids both the macOS sed -i portability issue and potential shell injection via unquoted file paths in backtick commands. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
force-pushed
the
diff-filter-portability
branch
from
ef60854 to
5554b2c
Compare
tautschnig
force-pushed
the
diff-filter-portability
branch
from
63b72b4 to
5554b2c
Compare
peterschrammel
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change impact analysis helper used
sedin ways not portable to macOS.