Use folder for each task#41
Draft
dhruvdcoder wants to merge 4 commits into
Draft
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 34.27% 33.49% -0.79%
==========================================
Files 120 120
Lines 10698 10698
Branches 1400 1400
==========================================
- Hits 3667 3583 -84
- Misses 6890 6976 +86
+ Partials 141 139 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task code under
xlm.tasksis reorganized so each task has its own package directory (src/xlm/tasks/<name>/__init__.py). Public Hydra dotted paths stay the same (for examplexlm.tasks.owt.preprocess_fn,xlm.tasks.safe_molgen.DeNovoEval), so existing YAML configs undersrc/xlm/configs/lightning_train/do not need bulk updates.This PR also adds contributor-facing documentation for wiring new tasks and fixes a few stale
molgenreferences in docs and examples.Details
cfg.py,owt.py, …) are renamed into subpackages with__init__.py.safe_molgennow contains the lazy facade,_safe_molgen_impl.py, andzinc_len.pkl; the lazy import targetsxlm.tasks.safe_molgen._safe_molgen_impl.xlm.taskspackage marker:src/xlm/tasks/__init__.pydocuments that this file is not a barrel export of every task symbol.setup.pypackage_datapath for the pickle is corrected totasks/safe_molgen/zinc_len.pkl(relative to thexlmpackage).xlm-models/mlm/configs/experiment/safe_mlm.yamllength_ref_fileupdated tosrc/xlm/tasks/safe_molgen/zinc_len.pkl.docs/guide/adding-a-task.mdand a link fromdocs/index.md.wiki/eval.mdexamples updated fromxlm.tasks.molgen/ “molgen” wording tosafe_molgen/ SAFE molecular generation where appropriate.composite_evaldocstring example now referencesxlm.tasks.safe_molgen.DeNovoEval.Backward compatibility
import xlm.tasks.<name>and_target_: xlm.tasks.<name>.<callable>behavior is preserved for unchanged symbol names.src/xlm/tasks/zinc_len.pklshould usesrc/xlm/tasks/safe_molgen/zinc_len.pkl(updated in-repo forsafe_mlm).Verification
ZINC_LENGTH_REF_FILEresolution.hydra.utils.get_method("xlm.tasks.owt.preprocess_fn")succeeds.pytest(for example datamodule / utils tests) as run locally before opening the PR.