Open
Conversation
Member
Author
|
Failing test appears to be unrelated. |
Contributor
|
🚀 Deployed on https://pr-1731--dhis2-ui.netlify.app |
cooper-joe
force-pushed
the
LIBS-531-input-counter
branch
from
4ed9a04 to
680edb2
Compare
cooper-joe
force-pushed
the
LIBS-531-input-counter
branch
from
680edb2 to
85531f6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements LIBS-531
Description
This PR adds a character count indicator to the
Inputcomponent. The counter is information only so the prop is namedcharacterCountLimitrather than the native<input>'smaxLength, which is actually enforced.There is some complexity to the way an
Inputwith bothcharacterCountLimitandclearabledisplay the end-aligned items. To avoid changing the existing implementation, the additional flex layout element is only used when bothcharacterCountLimitandclearableare present (which is not an expected common use case).I considered linking the character limit to the input's
errorprop, but for now validation remains the responsibility of the consumer.Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots