chore: yarn upgrade, node lts, lint warnings, code smells

[janhenrikoverland]

Spring cleaning:

• yarn upgrade
• node lts
• fix lint warnings
• fix code smells

[dhis2-bot]

🚀 Deployed on https://pr-3461.data-visualizer.netlify.dhis2.org

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cypress]

data-visualizer-app    Run #3141

Run Properties:   Failed #3141  •  a9e86c3a7b ℹ️: Merge 32693e971dce1483113abb523a65d80dd9fd3c6e into 8f45e41bd5260b82ee4d5b156147...

Project	data-visualizer-app
Branch Review	yarn-upgrade-and-node-lts
Run status	Failed #3141
Run duration	11m 42s
Commit	a9e86c3a7b ℹ️: Merge 32693e971dce1483113abb523a65d80dd9fd3c6e into 8f45e41bd5260b82ee4d5b156147...
Committer	Jan Henrik Øverland
View all properties for this run ↗︎

---

Test results
Failures	27
Flaky	2
Pending	0
Skipped	0
Passing	716
View all changes introduced in this branch ↗︎

---

Tests for review

  options/legend.cy.js • 1 failed test • e2e-chrome-parallel-42-3

View Output Video

Test		Artifacts
Options - Legend > applies different styles of legend to a Single Value chart		Test Replay Screenshots Video

  dimensions/orgUnit.cy.js • 6 failed tests • e2e-chrome-parallel-40-1

View Output Video

Test		Artifacts
Org unit dimension > selects a level - District		Test Replay Screenshots Video
Org unit dimension > deselects District		Test Replay Screenshots Video
Org unit dimension > selects a group - Eastern Area		Test Replay Screenshots Video
Org unit dimension > deselects Eastern Area		Test Replay Screenshots Video
Org unit dimension > selects a user org unit - 'User sub-units'		Test Replay Screenshots Video
Org unit dimension > deselects 'User sub-units'		Test Replay Screenshots Video

  visTypes/scatter.cy.js • 1 failed test • e2e-chrome-parallel-40-1

View Output Video

Test		Artifacts
Scatter chart > works correctly (create, save, load, swap etc)		Test Replay Screenshots Video

  options/legend.cy.js • 1 failed test • e2e-chrome-parallel-41-3

View Output Video

Test		Artifacts
Options - Legend > applies different styles of legend to a Single Value chart		Test Replay Screenshots Video

  options/axes.cy.js • 1 failed test • e2e-chrome-parallel-40-4

View Output Video

Test		Artifacts
Options - Auto-generated axis title > Multi items - single axis > config has vertical axis title "2 items and default black color		Test Replay Screenshots Video

The first 5 failed specs are shown, see all 12 specs in Cypress Cloud.

  dimensions/data.cy.js • 1 flaky test • e2e-chrome-parallel-40-4

View Output Video

Test		Artifacts
Data dimension > displays Data elements correctly		Test Replay Screenshots Video

  drillDown.cy.js • 1 flaky test • e2e-chrome-parallel-41-4

View Output Video

Test		Artifacts
Drill-down: Pivot table > navigates to the start page, changes vis type to Pivot table and adds a data item		Test Replay Screenshots Video