Skip to content

Run skill-creator analysis on all repository skills#20

Draft
Claude wants to merge 2 commits intomainfrom
claude/run-skill-creator-against-skills
Draft

Run skill-creator analysis on all repository skills#20
Claude wants to merge 2 commits intomainfrom
claude/run-skill-creator-against-skills

Conversation

@Claude
Copy link
Copy Markdown
Contributor

@Claude Claude AI commented Mar 11, 2026

Analyzed all 8 skills in the repository using skill-creator validation and best practices criteria.

Analysis Coverage

  • Validation: All skills pass structural requirements (YAML frontmatter, naming conventions, required fields)
  • Line count analysis: 2 skills exceed recommended 500-line threshold (linear-implement: 611, rspec-testing: 567)
  • Description quality: 3 skills identified with improvement opportunities for triggering accuracy
  • Documentation: 2 reference files >300 lines lack table of contents
  • Test infrastructure: No skills currently have evaluation test cases

Generated Artifacts

SKILL_ANALYSIS_REPORT.md: Comprehensive findings with prioritized recommendations organized by impact/effort

skill_analysis_report.json: Structured data for each skill including stats, bundled resources, and actionable findings

Key Recommendations

High priority:

  • Refactor linear-implement and rspec-testing to use progressive disclosure pattern (move detailed content to reference files)
  • Expand tdd-workflow description from 65 to ~200 chars with explicit trigger contexts

Medium priority:

  • Add TOCs to conventional-commits and rspec-testing reference files
  • Enhance codebase-readiness description with "when to use" guidance

All skills are production-ready; recommendations are optional enhancements aligned with skill-creator best practices.

Co-authored-by: dgalarza <105694+dgalarza@users.noreply.github.com>
@Claude Claude AI changed the title [WIP] Run skill-creator skill against all skills Run skill-creator analysis on all repository skills Mar 11, 2026
@dgalarza
Copy link
Copy Markdown
Owner

@copilot let's make issues from the findings / suggestions

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 11, 2026

@copilot let's make issues from the findings / suggestions

I wasn't able to create the issues directly — the GitHub API is blocked in this environment and the available MCP tools don't include issue creation. Here are the issues from the analysis findings, ready to create:


[High] Refactor linear-implement: reduce SKILL.md from 611 to <500 lines
Extract the detailed 14-step implementation guide into references/implementation-steps.md and Rails-specific patterns into references/rails-conventions.md, keeping only the high-level workflow in SKILL.md.


[High] Refactor rspec-testing: reduce SKILL.md from 567 to <500 lines
Move detailed examples and patterns into existing or new reference files, using the progressive disclosure pattern. The skill already has reference files (better_specs_guide.md, thoughtbot_patterns.md) that can absorb the content.


[High] Expand tdd-workflow description to improve triggering accuracy
Current description is only 65 chars and may undertrigger. Expand to ~200 chars including explicit trigger contexts ("use TDD", "test-first", "red-green-refactor", etc.).


[Medium] Add table of contents to conventional-commits/references/commit-examples.md
634-line reference file has no TOC, making navigation difficult.


[Medium] Add table of contents to rspec-testing/references/thoughtbot_patterns.md
407-line reference file has no TOC, making navigation difficult.


[Medium] Enhance codebase-readiness description with explicit trigger contexts
Description could be more explicit about when to invoke the skill (e.g., "Use when users want to assess code quality", "preparing for AI agents", etc.).


[Low] Add evaluation infrastructure for skills with testable outputs
No skills currently have evals/test-cases.json. Candidates: conventional-commits, parallel-code-review, process-meeting-transcript.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: `/usr/bin/gh gh issue create --title Refactor linear-implement: reduce SKILL.md from 611 to <500 lines using progressive disclosure --label enhancement --body ## Problem

The linear-implement skill's SKILL.md has 611 lines, exceeding the skill-creator recommended maximum of 500 lines. This affects loading performance and readability.

Recommendation

Extract the detailed step-by-step instructions into re` (http block)

  • Triggering command: /usr/bin/gh gh auth status (http block)
  • https://api.github.com/repos/dgalarza/claude-code-workflows
    • Triggering command: /usr/bin/curl curl -s -H Authorization: token ****** -H Accept: application/vnd.github.v3&#43;json REDACTED (http block)
  • https://api.github.com/repos/dgalarza/claude-code-workflows/issues
    • Triggering command: /usr/bin/curl curl -s -o /dev/null -w %{http_code} -X POST -H Authorization: token ****** -H Accept: application/vnd.github.v3&#43;json REDACTED -d {&#34;title&#34;:&#34;test&#34;,&#34;body&#34;:&#34;test&#34;} (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@dgalarza
Copy link
Copy Markdown
Owner

@copilot how do I get my repo set up so that gh actions run here by copilot have access to create new github issues?

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 17, 2026

@copilot how do I get my repo set up so that gh actions run here by copilot have access to create new github issues?

Two things need to be in place:

1. Grant issues: write permission in the workflow YAML

Any workflow that needs to create issues must declare the permission explicitly:

permissions:
  issues: write

This can be set at the job or top-level scope. Without it, GITHUB_TOKEN only gets read access to issues by default.

2. Allow GitHub Actions to create issues in repo settings

Go to Settings → Actions → General → Workflow permissions and ensure:

  • "Read and write permissions" is selected (or at minimum, confirm "Allow GitHub Actions to create and approve pull requests" is checked — issues follow the same gate)

Once both are set, any step in the workflow can use GITHUB_TOKEN to call the GitHub API or gh issue create to open issues.

Copilot AI requested a review from dgalarza March 17, 2026 14:22
@dgalarza
Copy link
Copy Markdown
Owner

@copilot I did item number 2 in the comment above. Can you take care of the first:

  1. Grant issues: write permission in the workflow YAML

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 17, 2026

@copilot I did item number 2 in the comment above. Can you take care of the first:

  1. Grant issues: write permission in the workflow YAML

I've added permissions: issues: write at the top level of .github/workflows/validate-skills.yml — this grants GITHUB_TOKEN write access to issues for all jobs in that workflow.

However, the push was blocked by a branch protection rule on this branch. You may need to temporarily relax the protection rule (or allow Copilot pushes) for the change to land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants