Conversation
Delete the following files: - FlinkDotNet/FlinkDotNet.DataStream/UnifiedSinkV2.cs - FlinkDotNet/FlinkDotNet.DataStream.Tests/UnifiedSinkV2ApiTests.cs - LocalTesting/LocalTesting.IntegrationTests/UnifiedSinkV2ConsolidatedTests.cs - docs/flink-20-features.md - docs/flink-21-features.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove all references to SinkWriterContext, UnifiedSinkV2Definition, SinkWriterConfig, SinkCommitterConfig, and BatchingConfig from test files, as the production code types have already been deleted. Files modified: - AdditionalDataClassesCoverageImprovementTests.cs: Remove SinkWriterContext_CanBeCreated test - CoverageImprovementForDataClassesTests.cs: Remove SinkWriterContext Property Coverage region - AdditionalCoverageFor95PercentTests.cs: Remove SinkWriterContext Tests region - PerformanceConfigModelTests.cs: Remove BatchingConfig, SinkWriterConfig, and v2 job definition tests - PerformanceFormatTests.cs: Remove Tests 2-5 that use v2 sink types - JobDefinitionModelTests.cs: Fix orphaned #endregion from prior v2 removal Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… ReducingState, AggregatingState), runtime contexts, Collector, ResultFuture, SourceOutput, and serialization Co-authored-by: devstress <30769729+devstress@users.noreply.github.com>
…tions Co-authored-by: devstress <30769729+devstress@users.noreply.github.com>
Co-authored-by: devstress <30769729+devstress@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement missing interfaces from documentation
Implement missing Apache Flink interfaces and remove v2 content
Mar 15, 2026
…tations The FlinkDotNet API is a pass-through translator from .NET to Flink Java IR. State management and runtime contexts are handled by the Flink Java runtime, not by in-memory .NET implementations. Removed files: - State/InMemoryValueState.cs, InMemoryListState.cs, InMemoryMapState.cs, InMemoryReducingState.cs, InMemoryAggregatingState.cs - Runtime/Contexts.cs, ListCollector.cs, ResultFuture.cs, Serialization.cs, SourceOutput.cs - Tests/InMemoryStateImplementationTests.cs, RuntimeImplementationTests.cs Co-authored-by: devstress <30769729+devstress@users.noreply.github.com>
…ava translation 76 tests that validate: - State interfaces (IValueState, IListState, IMapState, IReducingState, IAggregatingState) are pure API contracts - Context interfaces define correct members matching Java Flink API - Function interfaces enable user-defined functions with mocked runtime - State descriptors carry type info for IR translation - No in-memory state implementations exist in assembly - No runtime context implementations exist in assembly Co-authored-by: devstress <30769729+devstress@users.noreply.github.com>
Copilot
AI
changed the title
Implement missing Apache Flink interfaces and remove v2 content
Remove in-memory state/runtime implementations; add pass-through API contract tests
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous changes incorrectly added in-memory .NET implementations for state interfaces and runtime contexts. FlinkDotNet is a pass-through translator to Flink Java — state management and runtime contexts live in the Java runtime, not in .NET.
Removed (12 files, ~1800 lines)
InMemoryValueState,InMemoryListState,InMemoryMapState,InMemoryReducingState,InMemoryAggregatingStateProcessContext,KeyedProcessContext,OnTimerContext,WindowContext,ListCollector,ResultFuture,SourceOutput,JsonSerializationSchema,JsonDeserializationSchema,JsonSimpleVersionedSerializerInMemoryStateImplementationTests.cs,RuntimeImplementationTests.csAdded:
FlinkApiContractTests.cs(76 tests)IValueState,IListState,IMapState,IReducingState,IAggregatingState)The correct usage pattern — user code implements functions, Flink Java runtime provides context:
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.