Skip to content

Comments

feat: show check icon when editing list item#493

Open
nitinawari wants to merge 2 commits intodevsecopsmaturitymodel:mainfrom
nitinawari:feat-edit-mode-check-icon
Open

feat: show check icon when editing list item#493
nitinawari wants to merge 2 commits intodevsecopsmaturitymodel:mainfrom
nitinawari:feat-edit-mode-check-icon

Conversation

@nitinawari
Copy link

@nitinawari nitinawari commented Feb 20, 2026

close #491
Description:
Replaces the edit (pencil) icon with a check icon for list items that are currently being edited in the selectable list component. This provides a clearer UI indication and allows users to save their edits directly from the list.

DSOMM.-.Google.Chrome.2026-02-24.09-57-25.mp4

@vbakke vbakke self-requested a review February 21, 2026 13:37
Copy link
Collaborator

@vbakke vbakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nitinawari! I like this.

Since we are improving how to edit the list, would you mind adding another minor improvement?

When I use this page, I often end up doing:

  • click the main 'Edit pencil' to edit the list
  • then I click straight on the name I want to change

Could we catch the click on the name as well as clicking on the pencil for the name?

(I never got around to do it myself, and always got annoyed that I didn't when I was focusing on something different : )

@nitinawari
Copy link
Author

@vbakke
I like the suggestion. Just to confirm — do you want the entire input row to become clickable when the list is in edit mode, or only the item name text?

My initial thought is that making the whole row clickable might improve usability, but I’d like to confirm your preference before implementing it.

@vbakke
Copy link
Collaborator

vbakke commented Feb 21, 2026

Good! I like confirms. It make it easier to do the right thing first time around. :)
...
Hmmm.... I had to think. And realised that we cannot trigger 'edit text mode' when clicking on the row. Then we cannot select another row. So it has to be when clicking on the text only.

Clicking on the image below should select 'Internal`. Not change the name.

image

.

Soo... that leaves us with the question: What would a user expect of they clicked on the name?

  • A)

    • Click on row: select it
    • Click on name: edit name
  • B)

    • Click on row: select it
    • Click on name: select the row (as today)
    • Double click on name: edit name

What would you expect if you clicked on the name?
.

(And sorry for scope creeping this. But maybe we should hide the .edit-hint if the screen is too narrow? Like in the picture above. It just looks funny...)

@sawankshrma
Copy link
Contributor

What would you expect if you clicked on the name?

B) Double clicking to edit the name, I think.

@Klath123
Copy link
Contributor

@vbakke , as per my opinion I think The second option (B part) is more preferred. As it will prevent user from accidentally changing the name and also it will increase the UX as it is common feature across various platforms :)

@vbakke
Copy link
Collaborator

vbakke commented Feb 22, 2026

I agree. Go option B) 👍 @Klath123

@nitinawari nitinawari requested a review from vbakke February 24, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show check icon instead of edit icon when editing a list item

4 participants