#1726: Gradle updates not found by GradleUrlUpdater#1728
Open
SDallmann wants to merge 16 commits intodevonfw:mainfrom
Open
#1726: Gradle updates not found by GradleUrlUpdater#1728SDallmann wants to merge 16 commits intodevonfw:mainfrom
SDallmann wants to merge 16 commits intodevonfw:mainfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 22996998543Details
💛 - Coveralls |
hohwille
approved these changes
Mar 9, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@SDallmann thank you so much for this PR and fix. Excellent job that will be highly appreciated by our projects struggling with the issue.
I left some comments for improvement. It would be awesome if we can sync today to get this merged asap to unblock projects. Sorry for the delay due to my sickness leave.
cli/src/main/java/com/devonfw/tools/ide/github/GithubRelease.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/github/GithubRelease.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/github/GithubReleases.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/updater/GithubUrlReleaseUpdater.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 9, 2026
url-updater/src/main/java/com/devonfw/tools/ide/url/tool/gradle/GradleUrlUpdater.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 9, 2026
url-updater/src/main/java/com/devonfw/tools/ide/url/tool/gradle/GradleUrlUpdater.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Mar 9, 2026
url-updater/src/main/java/com/devonfw/tools/ide/url/tool/gradle/GradleUrlUpdater.java
Outdated
Show resolved
Hide resolved
…b.com/SDallmann/IDEasy into devonfw#1726-gradle-updates-not-found
…ed back to protected instead of public)
…b.com/SDallmann/IDEasy into devonfw#1726-gradle-updates-not-found
hohwille
approved these changes
Mar 10, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@SDallmann Thanks for your nice improvements. 👍
Sorry to be picky but I still have some review comments left. I hope it helps.
cli/src/main/java/com/devonfw/tools/ide/github/GithubRelease.java
Outdated
Show resolved
Hide resolved
url-updater/src/main/java/com/devonfw/tools/ide/url/updater/AbstractGithubUrlUpdater.java
Show resolved
Hide resolved
url-updater/src/test/java/com/devonfw/tools/ide/url/tool/gradle/GradleUrlUpdaterMock.java
Show resolved
Hide resolved
hohwille
approved these changes
Mar 12, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@SDallmann thanks for your excellent improvements. Now ready for merge 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1726
Implemented changes:
GithubUrlUpdatertoGithubUrlTagUpdater.GithubReleaseandGithubReleasesthat work likeGithubTagandGithubTagsrespectively, but handle references by@JsonProperty("tag_name")instead of@JsonProperty("ref").GithubUrlReleaseUpdaterthat handles Github URLs by release instead of tag.GradleUrlUpdaterto get URLs using the newly implementedGithubUrlReleaseUpdater.GithubReleaseandGithubReleasesChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal