Skip to content

#1726: Gradle updates not found by GradleUrlUpdater#1728

Open
SDallmann wants to merge 16 commits intodevonfw:mainfrom
SDallmann:#1726-gradle-updates-not-found
Open

#1726: Gradle updates not found by GradleUrlUpdater#1728
SDallmann wants to merge 16 commits intodevonfw:mainfrom
SDallmann:#1726-gradle-updates-not-found

Conversation

@SDallmann
Copy link
Contributor

This PR fixes #1726

Implemented changes:

  • Refactored GithubUrlUpdater to GithubUrlTagUpdater.
  • Added classes GithubRelease and GithubReleases that work like GithubTag and GithubTags respectively, but handle references by @JsonProperty("tag_name") instead of @JsonProperty("ref").
  • Added GithubUrlReleaseUpdater that handles Github URLs by release instead of tag.
  • Adapted GradleUrlUpdater to get URLs using the newly implemented GithubUrlReleaseUpdater.
  • Added tests for GithubRelease and GithubReleases

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@SDallmann SDallmann moved this from 🆕 New to Team Review in IDEasy board Mar 6, 2026
@hohwille hohwille added this to the release:2026.03.001 milestone Mar 9, 2026
@coveralls
Copy link
Collaborator

coveralls commented Mar 9, 2026

Pull Request Test Coverage Report for Build 22996998543

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 70.526%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%
com/devonfw/tools/ide/url/tool/gradle/GradleUrlUpdater.java 1 75.0%
Totals Coverage Status
Change from base Build 22996868406: 0.2%
Covered Lines: 10633
Relevant Lines: 14482

💛 - Coveralls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SDallmann thank you so much for this PR and fix. Excellent job that will be highly appreciated by our projects struggling with the issue.

I left some comments for improvement. It would be awesome if we can sync today to get this merged asap to unblock projects. Sorry for the delay due to my sickness leave.

@github-project-automation github-project-automation bot moved this from Team Review to 👀 In review in IDEasy board Mar 9, 2026
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SDallmann Thanks for your nice improvements. 👍
Sorry to be picky but I still have some review comments left. I hope it helps.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SDallmann thanks for your excellent improvements. Now ready for merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Gradle updates not found by GradleUrlUpdater

3 participants