Done

[backwizard]

Repository : our repository link 🌷🌥
Visualize : visualize notebook ✨

Team

• X
• Fah
• Alif

[annibuliful]

รบกวนใส่ link repo
ถ้ามี visualization ด้วยรบกวนใส่มาด้วยครับ

[pynsuphasueb]

Repository : our repository link 🌷🌥
Visualize : visualize notebook ✨

[annibuliful]

@backwizard @pynsuphasueb

เหมือนจะยังไม่มีไฟล์ JSON นะครับที่เป็นผลลัพธ์สุดท้าย

[backwizard]

File dev_club.json ใน folder resources ปะครับหรือผมเข้าใจอะไรผิด

[annibuliful]

เจอแล้วครับ เดี๋ยวผมมาตรวจครับผม ขอโทษครับ พอดีไฟล์เยอะจัดเลยอ่านไม่ละเอียดเอง

[annibuliful]

following Clean code book by Uncle Bob. you should create new variables to keep them be searchable

Suggested change

	def read_xml_to_list_of_dict(path: str) -> tuple[List[dict], List[dict]]:
	tree = ET.parse(path)
	root = tree.getroot()
	dev_mountain = []
	dev_club = []
	for child in root.iter('record'):
	row = {}
	for elem in child.iter():
	if elem.tag == "record":
	continue
	if elem.tag == "BIRTHDAY" or elem.tag == "HIRED":
	row[elem.tag] = datetime.strptime(elem.text, "%d-%m-%Y").strftime("%Y-%m-%d")
	continue
	row[elem.tag] = elem.text
	if check_hired_greater_than_3year(row["HIRED"]) \
	and row["POSITION"] in ["Airhostess", "Pilot", "Steward"] \
	and row["STATUS"] == "1" \
	and row["GENDER"] in ["0", "1"]:
	dev_club.append(row)
	continue
	if row["STATUS"] not in ["1", "2", "3"] and row["GENDER"] not in ["0", "1"]:
	continue
	dev_mountain.append(row)
	return dev_mountain, dev_club
	def read_xml_to_list_of_dict(path: str) -> tuple[List[dict], List[dict]]:
	STATUS = ["1", "2", "3"]
	GENDER = ["0", "1"]
	POSITION = ["Airhostess", "Pilot", "Steward"]
	tree = ET.parse(path)
	root = tree.getroot()
	dev_mountain = []
	dev_club = []
	for child in root.iter('record'):
	row = {}
	for elem in child.iter():
	if elem.tag == "record":
	continue
	if elem.tag == "BIRTHDAY" or elem.tag == "HIRED":
	row[elem.tag] = datetime.strptime(elem.text, "%d-%m-%Y").strftime("%Y-%m-%d")
	continue
	row[elem.tag] = elem.text
	if check_hired_greater_than_3year(row["HIRED"]) \
	and row["POSITION"] in POSITION \
	and row["STATUS"] == "1" \
	and row["GENDER"] in GENDER:
	dev_club.append(row)
	continue
	if row["STATUS"] not in STATUS and row["GENDER"] not in GENDER:
	continue
	dev_mountain.append(row)
	return dev_mountain, dev_club

[annibuliful]

Same as above

[annibuliful]

@backwizard ขอ email หน่อยครับ

[backwizard]

kongphopse@gmail.com ครับ

[annibuliful]

kongphopse@gmail.com

ทางเราจะส่ง pin password เพื่อสำหรับการยืนยันที่จะไปงานนะครับ เตรียมตัวอ่านเมล