feat(acp): add in-session mode/model/agent controls with ACP preference persistence#47
Open
feat(acp): add in-session mode/model/agent controls with ACP preference persistence#47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes ACP mode/model/agent configurable at runtime from the session header and persists those selections per session, with workspace defaults fallback for new/empty sessions. #40
Why
ACP mode/model/agent were not fully controllable from the session UI, and selections were not persisted in a way that supports consistent resume/new-session behavior.
What Changed
acp_set_config_option(workspace_id, session_id, config_id, option_id)mapped tosession/set_config_option(option_id-> ACPvalue).sessions.acp_preferences_jsoncolumnworkspace_acp_defaultstablesession_update_acp_preferencesworkspace_acp_defaults_getworkspace_acp_defaults_setforget_workspace_datato delete workspace ACP defaults for directory workspaces.planagentData Contract
acp_preferences_json:{ "modeId": "string | null", "selectedConfigOptions": { "configId": "optionId" } }