Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the container build process to avoid accidentally packaging stale Angular build artifacts (e.g., dist/ or ui/) that may exist in the Docker build context, and ensures enterprise builds can have their API placeholder replaced at runtime.
Changes:
- Extend
init.shto replace the##CONSOLE_SERVER_API##placeholder used by the enterprise environment configuration. - Adjust the Docker build artifact selection logic to prefer the
ui/browseroutput (enterprise) before falling back todist/samplewebui/browser. - Add
dist/,ui/,coverage/, and.angular/to.dockerignoreto prevent old build outputs/caches from being copied into the image build context.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
init.sh |
Adds runtime placeholder substitution for ##CONSOLE_SERVER_API## in built JS bundles. |
Dockerfile |
Prefer ui/browser over dist/samplewebui/browser when selecting the build output to package. |
.dockerignore |
Excludes common build outputs/caches from Docker context to prevent stale artifacts being packaged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device-management-toolkit/console#684
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )