Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates CIRA config handling so generateRandomPassword can be stored and retrieved through the CIRA config path without Postgres type mismatches, while keeping the external DTO/config layers boolean-based.
Changes:
- Switched
entity.CIRAConfig.GenerateRandomPasswordfrombooltostringto match the persisted CIRA config representation. - Added bool/string conversions in the CIRA config and profile use cases.
- Updated related tests/fuzz inputs to use the new string-backed entity field.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
internal/usecase/sqldb/ciraconfig.go |
Reads CIRA generate_random_password as text from the database and stores it on the entity as a string. |
internal/usecase/profiles/usecase.go |
Parses the string-backed CIRA flag back into a boolean when building provisioning config. |
internal/usecase/ciraconfigs/usecase.go |
Converts the DTO bool to/from the entity string representation. |
internal/usecase/ciraconfigs/usecase_test.go |
Adjusts mocked entity fixtures to the new string field type. |
internal/usecase/ciraconfigs/transform_fuzz_test.go |
Updates fuzz entity construction to use stringified bool values. |
internal/entity/ciraconfig.go |
Changes the entity model field type for GenerateRandomPassword. |
internal/controller/httpapi/v1/login.go |
Adds an issuer claim to locally generated JWTs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
==========================================
+ Coverage 39.81% 39.91% +0.09%
==========================================
Files 124 124
Lines 11395 11398 +3
==========================================
+ Hits 4537 4549 +12
+ Misses 6461 6453 -8
+ Partials 397 396 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 1.25.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.