Conversation
graikhel-intel
approved these changes
May 5, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
==========================================
- Coverage 39.92% 39.91% -0.02%
==========================================
Files 123 123
Lines 11355 11366 +11
==========================================
+ Hits 4534 4537 +3
- Misses 6424 6433 +9
+ Partials 397 396 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR aims to improve robustness around optional UI assets, reduce disruptive failures during browser auto-launch, and make certain DB migrations more tolerant to repeat application.
Changes:
- Add
httpapi.HasUI()(withnouivariant) and use it to skip browser launch when UI assets aren’t embedded. - Make browser launch failures non-fatal (log instead of panic).
- Update migration SQL to use
ADD COLUMN IF NOT EXISTSand improve the fatal error message when the local keyring is unavailable.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/controller/httpapi/ui.go | Adds HasUI() for non-noui builds by checking for embedded UI entrypoint. |
| internal/controller/httpapi/ui_noui.go | Adds HasUI() stub for noui builds. |
| internal/app/migrations/20251210000000_migrate_devices.up.sql | Makes device/cira column additions conditional via IF NOT EXISTS. |
| internal/app/migrations/20250701000000_migrate_uefi.up.sql | Makes profile column addition conditional via IF NOT EXISTS. |
| cmd/app/main.go | Skips browser launch when UI isn’t embedded; improves fatal error message for local keyring failures. |
| cmd/app/browser.go | Logs browser-launch failures instead of panicking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
+9
| ALTER TABLE devices ADD COLUMN IF NOT EXISTS mebxpassword TEXT; | ||
| ALTER TABLE devices ADD COLUMN IF NOT EXISTS mpspassword TEXT; | ||
|
|
||
| ALTER TABLE ciraconfigs ADD COLUMN generate_random_password TEXT; No newline at end of file | ||
| ALTER TABLE ciraconfigs ADD COLUMN IF NOT EXISTS generate_random_password TEXT; No newline at end of file |
| **********************************************************************/ | ||
|
|
||
| ALTER TABLE profiles ADD COLUMN uefi_wifi_sync_enabled BOOLEAN NOT NULL DEFAULT FALSE; No newline at end of file | ||
| ALTER TABLE profiles ADD COLUMN IF NOT EXISTS uefi_wifi_sync_enabled BOOLEAN NOT NULL DEFAULT FALSE; No newline at end of file |
|
🎉 This PR is included in version 1.24.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.