-
Notifications
You must be signed in to change notification settings - Fork 22
feat: implement cascading deletion for related records in delete #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kulikp1
wants to merge
12
commits into
main
Choose a base branch
from
feature/AdminForth/1256/cascading-deletion-
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ca65f67
feat: implement cascading deletion for related records in delete endp…
bda166a
add alowwedAction check
12d2ba6
add missing spaces
02e216b
feat: implement cascading deletion logic in delete endpoint
23d178b
fix: update check strategy
8b5b7b5
feat: refine cascading deletion logic in delete endpoint
01dfcfd
fix: update condition
ee04911
fix: change variable name foreignKeyColumn to foreignResourceColumn
96c2c8f
fix: add check for foreign resource onDelete strategy
a300f83
feat: add onDelete type
8ef2973
fix: delete strategy check
552ecdc
fix: add check for cascade strategy
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -618,7 +618,13 @@ export default class ConfigValidator implements IConfigValidator { | |
| errors.push(`Resource "${res.resourceId}" column "${col.name}" isArray is enabled but suggestOnCreate is not an array`); | ||
| } | ||
| } | ||
|
|
||
| if (col.foreignResource){ | ||
| if (col.foreignResource.onDelete){ | ||
| if (col.foreignResource.onDelete !== 'cascade' && col.foreignResource.onDelete !== 'setNull'){ | ||
| errors.push (`Wrong delete strategy you can use 'onDelete' or 'cascade'`); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mistake in message you have setNull and cascade strategies but your error message tells that you have onDelete or cascade |
||
| } | ||
| } | ||
| } | ||
| if (col.foreignResource) { | ||
| if (!col.foreignResource.resourceId) { | ||
| // resourceId is absent or empty | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You already have this check below
you can add your validation below
Also you can merge your two checks in one
like
if i have onDelete and onDelete is not cascade or setNull
throw error