feat: require key-value adapter for storing generated passkey challange#20
Open
yaroslav8765 wants to merge 3 commits intomainfrom
Open
feat: require key-value adapter for storing generated passkey challange#20yaroslav8765 wants to merge 3 commits intomainfrom
yaroslav8765 wants to merge 3 commits intomainfrom
Conversation
ivictbor
requested changes
Feb 21, 2026
BREAKING CHANGE: KeyValue adapter is required for passkeys.
ivictbor
requested changes
Feb 26, 2026
| private async checkIfChallengeInBlackList(challenge: string): Promise<boolean> { | ||
| const res = await this.options.passkeys.keyValueAdapter.get(challenge); | ||
| if (!res) { | ||
| this.saveChallengeToStorage(challenge, this.options.passkeys?.challengeValidityPeriod || '2m'); |
Contributor
There was a problem hiding this comment.
@yaroslav8765 "check" functions should not mutate state, this does not sound good,
100% better reading would be checkIfChellengeNotUsed() and separate method useChellenge()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.