Skip to content

Update project to go 1.23#1427

Merged
akurinnoy merged 2 commits into
mainfrom
update-go-1.23
May 6, 2025
Merged

Update project to go 1.23#1427
akurinnoy merged 2 commits into
mainfrom
update-go-1.23

Conversation

@dkwon17
Copy link
Copy Markdown
Collaborator

@dkwon17 dkwon17 commented May 3, 2025

What does this PR do?

Updates project to use go 1.23

What issues does this PR fix or reference?

Update to go 1.23 is needed to fix CVEs:
cve-2025-22869 which has a CVSS score of 7.5.
cve-2025-22872 which has a CVSS score of 6.5.

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Signed-off-by: David Kwon <dakwon@redhat.com>
@dkwon17 dkwon17 requested review from akurinnoy and ibuziuk as code owners May 3, 2025 04:21
@openshift-ci openshift-ci Bot added the approved label May 3, 2025
@dkwon17 dkwon17 requested a review from rohanKanojia May 3, 2025 04:21
Comment thread .ci/oci.Dockerfile
#

FROM registry.ci.openshift.org/openshift/release:golang-1.22
FROM registry.ci.openshift.org/openshift/release:golang-1.23

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.ci.openshift.org/openshift/release to registry.ci.openshift.org/openshift/release@sha256:cd5c68457b9da02df266e32f9e26d9c323d808acaadc35126c50a526051c1d89
Click Remediation section below for further remediation help
Comment thread build/Dockerfile

# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset
FROM registry.access.redhat.com/ubi9/go-toolset:9.5-1739267472 as builder
FROM registry.access.redhat.com/ubi9/go-toolset:1.23.6-1745328278 as builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.access.redhat.com/ubi9/go-toolset:1.23.6-1745328278 to registry.access.redhat.com/ubi9/go-toolset:1.23.6-1745328278@sha256:8a634d63713a073d7a1e086a322e57b148eef9620834fc8266df63d9294dff1b
Click Remediation section below for further remediation help
Comment thread project-clone/Dockerfile
# Build the manager binary
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset
FROM registry.access.redhat.com/ubi9/go-toolset:9.5-1739267472 as builder
FROM registry.access.redhat.com/ubi9/go-toolset:1.23.6-1745328278 as builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.access.redhat.com/ubi9/go-toolset:1.23.6-1745328278 to registry.access.redhat.com/ubi9/go-toolset:1.23.6-1745328278@sha256:8a634d63713a073d7a1e086a322e57b148eef9620834fc8266df63d9294dff1b
Click Remediation section below for further remediation help
@dkwon17 dkwon17 changed the title Update project to go 1.23 (#1424) Update project to go 1.23 May 3, 2025
Comment thread go.mod
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akurinnoy, dkwon17, ibuziuk, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk
Copy link
Copy Markdown
Contributor

ibuziuk commented May 5, 2025

@dkwon17 lgtm, but looks like there is a conflict in the Dockerfile

@openshift-ci openshift-ci Bot removed the lgtm label May 5, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 5, 2025

New changes are detected. LGTM label has been removed.

@akurinnoy akurinnoy merged commit 2275311 into main May 6, 2025
9 of 10 checks passed
@akurinnoy akurinnoy deleted the update-go-1.23 branch May 6, 2025 06:51
@dkwon17 dkwon17 mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants