Skip to content

Automatically add doctype before html tag if not present #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devashishdxt merged 1 commit into from
Mar 5, 2026
Merged

Automatically add doctype before html tag if not present #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions plait-macros/src/buffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,17 +349,23 @@ impl InnerBuffer {
children,
} = element;

self.static_str.push_str(&format!("<{}", tag.value()));
let tag_str = tag.value();

if tag_str == "html" && !self.static_str.ends_with("<!DOCTYPE html>") {
self.static_str.push_str("<!DOCTYPE html>");
}

self.static_str.push_str(&format!("<{}", tag_str));

for attribute in attributes {
self.push_attribute(attribute);
}

self.static_str.push('>');

if !is_void_element(&tag.value()) {
if !is_void_element(&tag_str) {
self.push_block(children);
self.static_str.push_str(&format!("</{}>", tag.value()));
self.static_str.push_str(&format!("</{}>", tag_str));
}
}

Expand Down
16 changes: 16 additions & 0 deletions plait/tests/html_macro_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,22 @@ fn test_html_macro_doctype() {
assert_eq!(html.to_html(), "<!DOCTYPE html>")
}

#[test]
fn test_html_macro_auto_doctype() {
let html = html! {
#doctype
html {}
};

assert_eq!(html.to_html(), "<!DOCTYPE html><html></html>");

let html = html! {
html {}
};

assert_eq!(html.to_html(), "<!DOCTYPE html><html></html>");
}

#[test]
fn test_html_macro_let_binding() {
let world = " World";
Expand Down