Skip to content

InputCompositionFix#39

Merged
derekriemer merged 3 commits into
derekriemer:masterfrom
keyang556:master
May 17, 2026
Merged

InputCompositionFix#39
derekriemer merged 3 commits into
derekriemer:masterfrom
keyang556:master

Conversation

@keyang556
Copy link
Copy Markdown
Contributor

nvda issue 14152 and 14140.

Comment thread addon/appModules/notepad++/editWindow.py Outdated
Copy link
Copy Markdown
Owner

@derekriemer derekriemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment. but I think overall this is fine. I'm curious if the supergeter thing is necessary or not. _get_textInfo is the method behind the autoproperty .textInfo, .Textinfo is automatically created by the class AutoPropertyType at runtime, so I'm not sure exactly if we have to do that at all even. Let me know if you figure out whether this is necessary or not and we can decide whether to merge yet or simplify

@keyang556 keyang556 marked this pull request as draft May 17, 2026 01:23
@keyang556 keyang556 marked this pull request as ready for review May 17, 2026 01:53
@keyang556
Copy link
Copy Markdown
Contributor Author

Deleted supergeter, check if this version OK?

@derekriemer
Copy link
Copy Markdown
Owner

derekriemer commented May 17, 2026

Congrats! I tested locally as best I can and things seem to work. merging now.
I'll make a new release on gh for you and add a followup commit adding you to the authors if you'd like. would you like to be listed in authors in readme? and if so, what name/email would you prefer?? "your name " is the form we've been using, but a name is also enough. I'm only adding maintainers who egularly contribute to the build vars authors at this point because that's what I use to give people permissions to contribute to the main addon store with.

@derekriemer derekriemer merged commit 94f6dc5 into derekriemer:master May 17, 2026
3 checks passed
@keyang556
Copy link
Copy Markdown
Contributor Author

Ken Chang lindsay714322@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants