Carbon Black Enterprise Protection - Content Pack Update#43696
Carbon Black Enterprise Protection - Content Pack Update#43696kamalq97 merged 12 commits intodemisto:contrib/whsmith1223_masterfrom
Conversation
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed. |
|
Hi @whsmith1223, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
🤖 AI-Powered Code Review AvailableHi @kamalq97, you can leverage AI-powered code review to assist with this PR! Available Commands:
|
|
Hi @whsmith1223 Thank you for your contribution! I am glad you managed to resolve the submission issues. Please generate updated pack release notes. Please contact me via the DFIR Community Slack to coordinate a demo. Refer to this page for our guidelines on demo preparation. |
|
For the Reviewer: Trigger build request has been accepted for this contribution PR. |
|
For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/7976032 |
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Thanks for submitting your PR!
Before moving on with the detailed review, please take a moment to address the following general comments.
- Your PR title and description are too generic. Please update the PR description to explicitly mention the addition of the
cbp-disable-userandcbp-retrieve-user-datacommands so the scope of the changes is clear.
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
kamalq97
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
Please ensure you address my comment below and please do not forget to generate a new release notes entry for the content pack.
Updated command names
whsmith1223
left a comment
There was a problem hiding this comment.
Changed command wording
…nBlackProtect.yml Co-authored-by: Kamal Qarain <45042524+kamalq97@users.noreply.github.com>
kamalq97
left a comment
There was a problem hiding this comment.
Thank you @whsmith1223!
I enjoyed our demo session today.
Please perform the minor changes below.
Once all is done, please run :
demisto-sdk generate-docs -i 'Packs/CarbonBlackProtect/Integrations/CarbonBlackProtect/CarbonBlackProtect.yml'
This will sync the YML changes to the README file. 😊
|
Made a couple commits for the proposed changes. We should be all good but let me know if anything else arises. I still need to run the demisto-sdk command but had to take off for the day. I'll look at that tomorrow. |
b501a53
into
demisto:contrib/whsmith1223_master
|
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
…ection (#43926) * Carbon Black Enterprise Protection - Content Pack Update (#43696) * Update CarbonBlackProtect.yml * Update README.md * Update pack_metadata.json * Update CarbonBlackProtect.py * Update CarbonBlackProtect.yml * Update README.md * Update CarbonBlackProtect.yml Updated command names * updated command wording * Update Packs/CarbonBlackProtect/Integrations/CarbonBlackProtect/CarbonBlackProtect.yml Co-authored-by: Kamal Qarain <45042524+kamalq97@users.noreply.github.com> * updated command output to be markdown * updated outputs in yml --------- Co-authored-by: Kamal Qarain <45042524+kamalq97@users.noreply.github.com> * Update release notes and fix validation erros --------- Co-authored-by: whsmith1223 <whsmith1223@gmail.com> Co-authored-by: Kamal Qarain <45042524+kamalq97@users.noreply.github.com> Co-authored-by: Kamal Qarain <kqarain@paloaltonetworks.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Must have
relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-16395