Agent improvement next

[Malcolmnixon]

Pull Request

Description

Improvement to the agents and linting files.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code quality improvement

Related Issues

N/A

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

• Code builds successfully: dotnet build --configuration Release
• All unit tests pass: dotnet test --configuration Release
• Code produces zero warnings

Code Quality

• Code formatting is correct: dotnet format --verify-no-changes
• New code has appropriate XML documentation comments
• Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

• All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

• Added unit tests for new functionality
• Updated existing tests if behavior changed
• All tests follow the AAA (Arrange, Act, Assert) pattern
• Test coverage is maintained or improved

Documentation

• Updated README.md (if applicable)
• Updated ARCHITECTURE.md (if applicable)
• Added code examples for new features (if applicable)
• Updated requirements.yaml (if applicable)

Additional Notes

N/A

[Copilot]

Pull request overview

This PR improves the repo’s agent/standards documentation and extends the lint scripts to run additional Continuous Compliance tooling (ReqStream/VersionMark/ReviewMark) alongside existing linters.

Changes:

• Extended lint.sh / lint.bat to restore dotnet tools and run ReqStream/VersionMark/ReviewMark lint steps, and to skip Puppeteer downloads during npm install.
• Added new universal standards (coding-principles.md, testing-principles.md) and introduced/expanded YAML frontmatter + “Required Standards” sections across several standards docs.
• Updated agent guidance (AGENTS.md, quality agent template) to reference the new standards and testing boundary checks.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
lint.sh	Adds Puppeteer skip + dotnet tool restore and new dotnet lint steps; changes dotnet format restore behavior.
lint.bat	Windows equivalent of the updated lint workflow (npm + dotnet tools + format).
AGENTS.md	Updates project structure placeholders and adds new standards to the “Standards Application” list.
.github/standards/testing-principles.md	New universal testing principles doc (AAA + dependency boundaries + quality gates).
.github/standards/technical-documentation.md	Adds YAML frontmatter and new guidance for “References” sections.
.github/standards/software-items.md	Adds YAML frontmatter and clarifies subsystem/unit definitions.
.github/standards/reviewmark-usage.md	Adds YAML frontmatter and “Required Standards” dependency note.
.github/standards/reqstream-usage.md	Adds YAML frontmatter, required-standards note, and clarifies downward-only links wording.
.github/standards/design-documentation.md	Adds YAML frontmatter, required-standards note, and clarifies scope exclusions (tests).
.github/standards/csharp-testing.md	Adds YAML frontmatter, links to universal testing principles, and trims duplicated requirements-coverage guidance.
.github/standards/csharp-language.md	Adds YAML frontmatter and refocuses on coding principles + formatting/quality checks.
.github/standards/coding-principles.md	New universal coding principles doc (literate coding, architecture principles, quality gates).
.github/agents/quality.agent.md	Updates quality report checklist to include hierarchy-boundary checks; repositions Result-field guidance.

Comments suppressed due to low confidence (1)

.github/standards/csharp-language.md:49

• This standard is internally inconsistent: coding-principles.md says documentation is required on ALL public members, while this file’s quality check says XmlDoc is complete on "all members". Clarify and align the requirement (public-only vs all members) to avoid conflicting guidance and enforcement.

# Quality Checks

- [ ] Zero compiler warnings (`TreatWarningsAsErrors=true`)
- [ ] XmlDoc documentation complete on all members

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Malcolmnixon]

@copilot apply changes based on the comments in this thread

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Malcolmnixon]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Done in 90005b9 — removed **/*.csproj and **/*.sln from the File Patterns section, keeping the standard scoped to C# source code only.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Malcolmnixon]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Done in 917f008 — coding-principles.md now requires documentation on ALL members, not just public ones.