Add --result as alias for --results; remove erroneous src/.config#166
Merged
Malcolmnixon merged 1 commit intomainfrom Apr 14, 2026
Merged
Add --result as alias for --results; remove erroneous src/.config#166Malcolmnixon merged 1 commit intomainfrom
Malcolmnixon merged 1 commit intomainfrom
Conversation
Agent-Logs-Url: https://github.com/demaconsulting/ReqStream/sessions/8fb65f0f-98c3-4a71-8da4-d1fc189eff0a Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Malcolmnixon
April 13, 2026 22:57
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a backward-compatible CLI flag alias (--result) for the existing --results option, and removes an erroneously committed empty .NET tool manifest from an incorrect location.
Changes:
- Add
--resultas a legacy alias for--resultsin CLI parsing, preserving flag-specific error messages. - Add unit tests covering
--result <file>and--resultwithout a filename. - Delete the mistakenly located empty
dotnet-tools.jsonundersrc/.../.config/.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/DemaConsulting.ReqStream/Cli/Context.cs |
Adds --result as an alias to the existing --results parsing branch, reusing the existing validation/error-message pattern. |
test/DemaConsulting.ReqStream.Tests/Cli/ContextTests.cs |
Adds coverage ensuring the alias sets ResultsFile and that missing filename errors mention --result. |
src/DemaConsulting.ReqStream/.config/dotnet-tools.json |
Removes an empty tool manifest that was committed under an incorrect path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds
--resultas an undocumented legacy alias for--resultsin CLI argument parsing. Also removes an emptydotnet-tools.jsonthat was mistakenly placed undersrc/DemaConsulting.ReqStream/.config/instead of the repository root.CLI alias (
Context.cs)The error message reflects whichever form was passed, e.g.
--result requires a filename argument.Tests (
ContextTests.cs)Context_Create_ResultFlag_SetsResultsFileProperty—--result <file>setsResultsFileContext_Create_MissingResultFilename_ThrowsException—--resultwith no filename throws with the correct messageCleanup
src/DemaConsulting.ReqStream/.config/dotnet-tools.json(empty tools file, erroneous location)Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.ReqStream --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
--resultis intentionally not documented in README or user guide — users should use--results. It exists solely for backward compatibility.