feat: add --result as alias for --results#161
Merged
Malcolmnixon merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/demaconsulting/BuildMark/sessions/16b62eed-223c-44b9-84d1-56c0a97396ad Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Malcolmnixon
April 14, 2026 01:32
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a legacy/convenience CLI alias --result that behaves identically to the canonical --results flag when specifying the validation results output file.
Changes:
- Added
--resultas a fall-through alias to the existing--resultsparsing branch. - Added unit tests validating
--resultsetsResultsFilecorrectly. - Added unit test validating
--resultwithout a value throws the expectedArgumentExceptionmessage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/DemaConsulting.BuildMark/Cli/Context.cs | Adds case "--result": to reuse the existing --results argument parsing and error behavior. |
| test/DemaConsulting.BuildMark.Tests/Cli/CliTests.cs | Adds a test ensuring --result sets ResultsFile in the CLI context creation path. |
| test/DemaConsulting.BuildMark.Tests/Cli/ContextTests.cs | Adds tests for --result happy path and missing-value error message behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds
--resultas a legacy/convenience alias for--results. The alias is intentionally undocumented —--resultsremains the canonical form.Changes:
src/.../Cli/Context.cs— Addedcase "--result":fall-through to the existing--resultsbranch in the argument parser switchtest/.../Cli/CliTests.cs— AddedCli_ResultFlag_SetsPropertycovering the alias happy pathtest/.../Cli/ContextTests.cs— Added tests for alias happy path (Context_Create_ResultArgument_SetsResultsFileProperty) and missing-value error (Context_Create_ResultWithoutValue_ThrowsArgumentException)Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.BuildMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
./lint.sh(Unix/macOS) orcmd /c lint.bat/./lint.bat(Windows)Testing
Documentation
Additional Notes
The alias produces the expected error message when used without a value:
--result requires a results filename argument.