server: Fix market buy funding validation.#3546
Merged
JoeGruffins merged 1 commit intodecred:masterfrom Mar 5, 2026
Merged
Conversation
For market buy orders, swapVal was set to the market buy buffer minimum rather than the actual order quantity. This caused ValidateOrderFunding to combine a small swapVal with the full lot count, producing an inflated fee estimate that exceeded the provided coin value.
JoeGruffins
force-pushed
the
marketbuybug
branch
from
0ffdf19 to
98c6cf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For market buy orders, swapVal was set to the market buy buffer minimum rather than the actual order quantity. This caused ValidateOrderFunding to combine a small swapVal with the full lot count, producing an inflated fee estimate that exceeded the provided coin value.