peer: Correct listener tests pver change.#3628
Merged
davecgh merged 1 commit intodecred:masterfrom Mar 3, 2026
Merged
Conversation
davecgh
force-pushed
the
peer_correct_listener_tests
branch
from
62628f4 to
a485b75
Compare
The code that introduced version 2 address messages added a protocol version to the listener tests since version 1 address messages are no longer valid under the latest protocol version. Unfortunately, it was not done correctly which leads to intermittent test failures. This updates the logic to use the appropriate locks and ensure the async reader is actually reading with the expected changed protocol version accordingly.
davecgh
force-pushed
the
peer_correct_listener_tests
branch
from
a485b75 to
839f836
Compare
jrick
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that introduced version 2 address messages added a protocol version to the listener tests since version 1 address messages are no longer valid under the latest protocol version.
Unfortunately, it was not done correctly which leads to intermittent test failures.
This updates the logic to use the appropriate locks and ensure the async reader is actually reading with the expected changed protocol version accordingly.