Open
Conversation
hardcoretime
force-pushed
the
fix/dvcr/improve-importer-logging
branch
4 times, most recently
from
9550884 to
47db2cc
Compare
- Ensure upload layer errors are not missed. - Wrap "DVCR is out of space" error. Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
hardcoretime
force-pushed
the
fix/dvcr/improve-importer-logging
branch
from
47db2cc to
7a7c810
Compare
hardcoretime
requested review from
Isteb4k,
diafour and
yaroslavborbat
as code owners
Contributor
|
Workflow has started. |
Contributor
|
Workflow has started. |
Isteb4k
requested changes
Feb 24, 2026
| "github.com/google/go-containerregistry/pkg/authn" | ||
| "github.com/google/go-containerregistry/pkg/name" | ||
| "github.com/google/go-containerregistry/pkg/v1" | ||
| v1 "github.com/google/go-containerregistry/pkg/v1" |
Contributor
There was a problem hiding this comment.
Alias is not needed if it matches the package directory
| resultCh := make(chan error, 2) | ||
|
|
||
| go func() { | ||
| resultCh <- p.inspectAndStreamSourceImage( |
Contributor
There was a problem hiding this comment.
Wrap the errors so it’s clear where they come from.
| return p.inspectAndStreamSourceImage(ctx, sourceImageFilename, sourceImageSize, progressMeter, pipeWriter, informer) | ||
| }) | ||
| errsGroup.Go(func() error { | ||
| resultCh := make(chan error, 2) |
|
|
||
| informer := NewImageInformer() | ||
|
|
||
| errsGroup, ctx := errgroup.WithContext(ctx) |
Contributor
There was a problem hiding this comment.
Lost the context cancellation if one of the goroutines returns an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
This is required to improve user experience because the current message is not clear enough to indicate that DVCR is out of space.
What is the expected result?
When DVCR is out of space, a resource will contain a clearer message about it in the condition.
Checklist
Changelog entries