fix: integration of destinations api in communities#7558
Conversation
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
|
@claude review |
|
Claude finished @sandrade-dcl's task in 1m 16s —— View job Code Review
SummaryThis PR correctly migrates Communities from the deprecated Places API methods to the new Destinations API equivalents across four files. The changes are minimal and well-scoped — all three call sites are updated to use the new methods, and Issues FoundNo blocking issues introduced by this PR. One pre-existing bug worth noting (not introduced here, flagged for visibility):
foreach (Profile.CompactInfo profile in getAvatarsDetailsResult)
{
userNames.Add(profile.UserId, profile.Name);
break; // ← exits after first profile — all other owners are lost
}This causes owner names to appear empty for any place whose owner isn't the first profile returned. Fix: remove the REVIEW_RESULT: PASS ✅ |
|
@claude re-review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
1 similar comment
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
DafGreco
left a comment
There was a problem hiding this comment.
✔️ PR reviewed and approved by QA on Both platforms following instructions playing both happy and un-happy path
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- [✔️ ] Log In/Log Out
- [✔️ ] Backpack and wearables in world
- [✔️ ] Emotes in world and in backpack
- [ ✔️] Teleport with map/coordinates/Jump In
- [ ✔️] Chat and multiplayer
- [ ✔️] Profile card
- [ ✔️] Camera
- [✔️ ] Skybox
This fix has been applied to zone only and we are still waiting for the deploy in org in order to have this community issue fixed ✅ We made the comparisson between org and zone and indeed the fix is working properly.
Please when the release comes check the status of the fix with @AndresMorelos to see if this has been deployed in org
Evidence:
Pull Request Description
Fix #7304
Fix #7329
What does this PR change?
Deprecates old
placesendpoints and integrates the newdestinationsones in the Communities feature.Test Steps
Check (in
.zonefor now... and later in.orgonce Alejo/Andrés confirm they deployed their back-end changes in.org) that Communities keep working as expected, especially when it comes to the relationship between community and its asociated places/worlds.Code Review Reference
Please review our Code Review Standards before submitting.