Skip to content

fix: integration of destinations api in communities#7558

Merged
sandrade-dcl merged 6 commits intodevfrom
fix/destinations-api-integration
Mar 27, 2026
Merged

fix: integration of destinations api in communities#7558
sandrade-dcl merged 6 commits intodevfrom
fix/destinations-api-integration

Conversation

@sandrade-dcl
Copy link
Copy Markdown
Contributor

@sandrade-dcl sandrade-dcl commented Mar 13, 2026

Pull Request Description

Fix #7304
Fix #7329

What does this PR change?

Deprecates old places endpoints and integrates the new destinations ones in the Communities feature.

Test Steps

Check (in .zone for now... and later in .org once Alejo/Andrés confirm they deployed their back-end changes in .org) that Communities keep working as expected, especially when it comes to the relationship between community and its asociated places/worlds.

Code Review Reference

Please review our Code Review Standards before submitting.

@sandrade-dcl sandrade-dcl self-assigned this Mar 13, 2026
@sandrade-dcl sandrade-dcl requested review from a team as code owners March 13, 2026 15:42
@github-actions github-actions Bot requested review from dalkia and daniele-dcl March 13, 2026 15:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 13, 2026

@sandrade-dcl sandrade-dcl changed the title fix: Integration of Destinations API in Communites fix: Integration of Destinations API in Communities Mar 13, 2026
@sandrade-dcl
Copy link
Copy Markdown
Contributor Author

@claude review

@decentraland decentraland deleted a comment from claude Bot Mar 13, 2026
@decentraland decentraland deleted a comment from claude Bot Mar 13, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Mar 13, 2026

Claude finished @sandrade-dcl's task in 1m 16s —— View job


Code Review

  • Gather context and read changed files
  • Analyze code for issues
  • Post review findings

Summary

This PR correctly migrates Communities from the deprecated Places API methods to the new Destinations API equivalents across four files. The changes are minimal and well-scoped — all three call sites are updated to use the new methods, and [Obsolete] attributes are added to the old interface methods.


Issues Found

No blocking issues introduced by this PR.

One pre-existing bug worth noting (not introduced here, flagged for visibility):

PlacesSectionController.cs lines 246–250break after the first profile insert means only the first profile gets added to userNames; all subsequent owner names are silently dropped:

foreach (Profile.CompactInfo profile in getAvatarsDetailsResult)
{
    userNames.Add(profile.UserId, profile.Name);
    break;  // ← exits after first profile — all other owners are lost
}

This causes owner names to appear empty for any place whose owner isn't the first profile returned. Fix: remove the break. Fix this →


REVIEW_RESULT: PASS ✅

@decentraland decentraland deleted a comment from claude Bot Mar 13, 2026
@sandrade-dcl
Copy link
Copy Markdown
Contributor Author

@claude re-review

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Mar 25, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

1 similar comment
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Mar 25, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@sandrade-dcl sandrade-dcl changed the title fix: Integration of Destinations API in Communities fix: integration of destinations api in communities Mar 26, 2026
Copy link
Copy Markdown

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on Both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • [✔️ ] Log In/Log Out
  • [✔️ ] Backpack and wearables in world
  • [✔️ ] Emotes in world and in backpack
  • [ ✔️] Teleport with map/coordinates/Jump In
  • [ ✔️] Chat and multiplayer
  • [ ✔️] Profile card
  • [ ✔️] Camera
  • [✔️ ] Skybox

This fix has been applied to zone only and we are still waiting for the deploy in org in order to have this community issue fixed ✅ We made the comparisson between org and zone and indeed the fix is working properly.

Please when the release comes check the status of the fix with @AndresMorelos to see if this has been deployed in org

Evidence:

Screen.Recording.2026-03-27.at.10.43.34.mov
20260327-1011-24.9658222.mp4

@sandrade-dcl sandrade-dcl merged commit 36f5dbb into dev Mar 27, 2026
11 of 13 checks passed
@sandrade-dcl sandrade-dcl deleted the fix/destinations-api-integration branch March 27, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QA] Communities | Cannot add a place to a community [QA] Communities | Chiri Storytelling – Worlds, Events & Photos Inconsistencies

4 participants