Merged
Conversation
…nd delayed play due to the same reason.
…erent CharacterMaskedEmoteComponent - minor fixes
…entering the scene
# Conflicts: # Explorer/Assets/DCL/AvatarRendering/AvatarShape/Assets/Animator/CharacterAnimator.controller # Explorer/Assets/DCL/AvatarRendering/AvatarShape/Assets/AvatarBase.prefab # Explorer/Assets/DCL/AvatarRendering/AvatarShape/UnityInterface/AvatarBase.cs # Explorer/Assets/DCL/AvatarRendering/Emotes/Systems/Play/CharacterEmoteSystem.cs # Explorer/Assets/DCL/AvatarRendering/Emotes/Tests/UpdateEmoteInputSystemShould.cs # Explorer/Assets/DCL/Infrastructure/SceneRunner/SceneInstanceDeps.cs # Explorer/Assets/DCL/Infrastructure/Utility/Animations/AnimationHashes.cs # Explorer/Assets/Protocol/DecentralandProtocol/Comms.gen.cs # Explorer/Packages/packages-lock.json # scripts/package-lock.json # scripts/package.json
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
…hrough new exposed APIs - Modified glTFast import settings to explicitly request CPU readable textures - Replaced draco dependency as per glTFast recommendation
Contributor
PR 7462PR number: 7462 Intel Core i3Change samples: 2672
|
This was referenced Apr 3, 2026
- Fixed inconsistencies with masked emote state on remote clients
# Conflicts: # Explorer/Assets/Protocol/DecentralandProtocol/Floats.gen.cs.meta # Explorer/Assets/Protocol/DecentralandProtocol/ParticleSystem.gen.cs.meta # scripts/package-lock.json # scripts/package.json
Ludmilafantaniella
approved these changes
Apr 10, 2026
Contributor
Ludmilafantaniella
left a comment
There was a problem hiding this comment.
QA Result: ✅ Approved
Tested on Windows and Mac using the world provided by the dev (nebi.dcl.eth).
What was tested:
- Upper body masked emote triggers correctly via green box — legs continue locomotion unaffected
- Walk, run and jump during masked emote — lower body movement unaffected
- Exit and re-enter scene — masked emote pauses and resumes correctly
- Full body emote triggered while masked emote is active — masked emote stops and resumes on end
- Gliding while masked emote is playing — masked emote stops and resumes on end
- Remote player's masked emote renders correctly on upper body layer
- Scene reload — all state resets correctly, no stuck masked emote
- stopEmote() — both local and remote masked emotes stop cleanly
- Quick enter/exit edge case — no stuck state
- Full body emotes on remote players — no regression
Notes:
- Some issues were found during testing and have been fixed. Thread for context here.
- One sync issue remains but is unrelated to this branch — it also occurs in prod in scenes like Genesis Plaza.
7562-evi.1.mp4
✅Smoke Test performed:
- ✔️ Backpack and wearables in world
- ✔️ Emotes in world and in backpack
- Scene Emotes on Genesis Plaza
- Scene with auto emote: The Inn & Goerli
- ✔️ Teleport with map/coordinates/Jump In
- ✔️ Chat and multiplayer
- ✔️ Profile card
- ✔️ Camera
- ✔️ Skybox
alejandro-jimenez-dcl
requested changes
Apr 13, 2026
Contributor
alejandro-jimenez-dcl
left a comment
There was a problem hiding this comment.
Left some comments. Great work!
…pan only when needed - Refactored TryCancelMaskedEmote to return a bool as expected (removed StopAndResetMaskedEmote too) - Only left messageBus.Send() wrapped in the try/catch - Removed callback from TriggerSceneEmoteAsync and refactored using correct async flow
alejandro-jimenez-dcl
approved these changes
Apr 14, 2026
# Conflicts: # Explorer/Assets/DCL/Multiplayer/Emotes/MultiplayerEmotesMessageBus.cs
# Conflicts: # Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs # Explorer/Assets/DCL/Infrastructure/Utility/Utility.asmdef # Explorer/Assets/DCL/PluginSystem/Global/EmotePlugin.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
protocol PR
js-sdk-toolchain PR
sdk7-test-scenes PR
What does this PR change?
Implements avatar masks for the emote system, enabling partial-body (upper body) emote animations alongside full-body movement. This allows scenes to trigger emotes that only affect specific avatar parts while preserving locomotion on the rest of the body.
Test Instructions
These instructions are meant to be used in the
88,-13-avatar-masks-test-scenefrom this PR.Test Steps
stopEmote()from scene — verify both local and remote masked emotes stop cleanlyAdditional Testing Notes
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.