Skip to content

fix: Improve UX when minting more than 50 NFTs in a single transaction#3366

Closed
JiwaniZakir wants to merge 1 commit intodecentraland:masterfrom
JiwaniZakir:fix/issue-3365
Closed

fix: Improve UX when minting more than 50 NFTs in a single transaction#3366
JiwaniZakir wants to merge 1 commit intodecentraland:masterfrom
JiwaniZakir:fix/issue-3365

Conversation

@JiwaniZakir
Copy link
Copy Markdown

Fixes #3365

Previously, users could configure mints exceeding MAX_NFTS_PER_MINT in MintItemsModal and attempt to submit the transaction, only receiving an error after the fact. The modal had no pre-submission validation against the per-transaction mint limit. MintItemsModal.tsx now computes exceedsLimit by comparing totalMints against MAX_NFTS_PER_MINT after the reduce, disables the submit button via isDisabled, and surfaces a localized warning via t('mint_items_modal.limit_reached') in the existing error row before the user attempts submission. Verified by manually entering mint amounts exceeding 50 and confirming the button disables and the error message renders inline.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 17, 2026

@JiwaniZakir is attempting to deploy a commit to the Decentraland Team on Vercel.

A member of the Team first needs to authorize it.

@RocioCM
Copy link
Copy Markdown
Member

RocioCM commented Apr 15, 2026

Closing as the issue is already solved by #3367

@RocioCM RocioCM closed this Apr 15, 2026
@JiwaniZakir
Copy link
Copy Markdown
Author

The inline validation approach is solid — catching the limit before submission is much better UX than surfacing a transaction error after the fact. One thing worth confirming: does exceedsLimit also handle the edge case where individual item quantities are modified after an initial valid total, or does it only recompute on explicit user input changes? Also, since @cyaiox noted this is fixed in #3367, it may be worth checking whether that PR's implementation handles the same validation path before closing this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve UX when minting more than 50 NFTs in a single transaction

2 participants