fix: show WalletConnect instead of MetaMask on mobile MetaMask browser for non-FULL sign-in modes#342
Open
fix: show WalletConnect instead of MetaMask on mobile MetaMask browser for non-FULL sign-in modes#342
Conversation
…r for non-FULL sign-in modes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
LautaroPetaccio
left a comment
LautaroPetaccio
left a comment
There was a problem hiding this comment.
I think we might be over engineering this hook. The targetConfig.ts file already checks if the user is on mobile or not, and the adjustWeb3OptionsForMobile() adjusts it as well, so by the time the connection options arrive to this hook, they're already set.
If we want to change what is seeing in each one, we should modify those files. This hook can either show one, two or no options depending on what's received from the connections options.
WDYR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window.ethereum.isMetaMask+ mobile user agent) and swaps MetaMask for WalletConnect as the preferred wallet option