Open
Conversation
Deploying adr with
|
| Latest commit: |
b72f03f
|
| Status: | 🚫 Build failed. |
aixaCode
reviewed
Aug 25, 2025
|
|
||
| ### Privacy | ||
|
|
||
| — Althought there will always be ways for players to eavesdrop on a voice chat, each explorer should display the list of players who are taking part in the conversation. Thanks to that, players can be sure of the privacy of their conversation. |
Contributor
There was a problem hiding this comment.
Small typo
Suggested change
| — Althought there will always be ways for players to eavesdrop on a voice chat, each explorer should display the list of players who are taking part in the conversation. Thanks to that, players can be sure of the privacy of their conversation. | |
| — Although there will always be ways for players to eavesdrop on a voice chat, each explorer should display the list of players who are taking part in the conversation. Thanks to that, players can be sure of the privacy of their conversation. |
|
|
||
| - Voice chats are exclusive to each scene. A single voice chat can't span players from different scenes. | ||
|
|
||
| - Players should be ablele to see a video stream from a scene while in a voice chat. We don't want more than one channel where the player can speak, but they should be able to consume other streams passively. For example, a scene might stream music while the player is in a voice chat. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Players should be ablele to see a video stream from a scene while in a voice chat. We don't want more than one channel where the player can speak, but they should be able to consume other streams passively. For example, a scene might stream music while the player is in a voice chat. | |
| - Players should be able to see a video stream from a scene while in a voice chat. We don't want more than one channel where the player can speak, but they should be able to consume other streams passively. For example, a scene might stream music while the player is in a voice chat. |
| ) | ||
| ``` | ||
|
|
||
| In this example, a trigger area is conencting to a hardcoded room number *1*. The scene could have N trigger areas, each with its own separate room number ID hardcoded. |
Contributor
There was a problem hiding this comment.
Should we have also some error handling if for some reason the backend fails so the scene can react?
| The function `DisconnectFromVoiceChat()` doesn't need to pass a room ID, since the player will be disconnected from the voice chat they are currently in. | ||
|
|
||
| There is no limit to the amount of room IDs that a scene can handle. On the backend, only active voice chats with multiple users consume voice resources. | ||
| The backend will handle the connection to the voice chat room and the disconnection from the voice chat room. |
Contributor
There was a problem hiding this comment.
How would the creator know that the use have been connected to the voice chat? Maybe we could have some events, so we can avoid polling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.