Open
Conversation
Deploying adr with
|
| Latest commit: |
a8fa355
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8dbd5e93.adr-cvq.pages.dev |
| Branch Preview URL: | https://skybox-time.adr-cvq.pages.dev |
pravusjif
reviewed
Mar 17, 2025
pravusjif
reviewed
Mar 17, 2025
pravusjif
approved these changes
Mar 20, 2025
Renamed time property to match the field supported in `scene.json` Added examples Signed-off-by: Alejandro Alvarez Melucci <163010988+AlejandroAlvarezMelucciDCL@users.noreply.github.com>
hukasu
reviewed
Feb 12, 2026
|
|
||
| The current protocol supports allowing a scene to have a fixed time of day, but it doesn't allow the creators to change it on the fly. | ||
|
|
||
| This is a problem if we want to make time of day feel more dynamic and alive. It could be used as a narrative element, or to enhance the experience of a scene, ie: have the sun come up on queue at the end of a dj set. |
There was a problem hiding this comment.
Suggested change
| This is a problem if we want to make time of day feel more dynamic and alive. It could be used as a narrative element, or to enhance the experience of a scene, ie: have the sun come up on queue at the end of a dj set. | |
| This is a problem if we want to make time of day feel more dynamic and alive. It could be used as a narrative element, or to enhance the experience of a scene, ie: have the sun come up on cue at the end of a dj set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.