Skip to content

DECAF-26 - fix page directive menu label #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
demersonmcarvalho merged 1 commit into from
Feb 9, 2026
Merged

DECAF-26 - fix page directive menu label #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/lib/components/modal/modal.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,12 @@ export class ModalComponent extends NgxParentComponentDirective implements OnIni
* @returns {Promise<void>} - A promise that resolves when the event is handled.
*/
override async handleEvent(event: IBaseCustomEvent): Promise<void> {
// if (event instanceof Event || event.name === ComponentEventNames.Refresh) {
// if (event instanceof Event) {
// event.stopImmediatePropagation();
// }
// return;
// }
if (event instanceof Event) {
event.stopImmediatePropagation();
}
Expand Down
7 changes: 5 additions & 2 deletions src/lib/engine/NgxPageDirective.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,11 @@ export abstract class NgxPageDirective extends NgxComponentDirective implements
if (!menu) menu = this.menu;
const activeMenu = menu.find((item) => item?.url?.includes(route));
if (activeMenu) {
const label = `${(activeMenu?.title || activeMenu?.label || '').toLowerCase()}`;
const title = `${await this.translate(label ? 'menu.' + label : label)} ${this.appName ? `- ${this.appName}` : ''}`;
let label = `${(activeMenu?.title || activeMenu?.label || '').toLowerCase()}`;
if (!label.startsWith('menu.')) {
label = `menu.${label}`;
}
const title = `${await this.translate(label)} ${this.appName ? `- ${this.appName}` : ''}`;
this.titleService.setTitle(title);
if (!this.title) this.title = title;
}
Expand Down
Loading