WIP - implement support for DICOM-RTSS#305
Open
dxlin wants to merge 1 commit intodcmjs-org:masterfrom
Open
Conversation
pieper
reviewed
Aug 29, 2022
| @@ -0,0 +1,470 @@ | |||
| import { DicomMetaDictionary } from "../DicomMetaDictionary.js"; | |||
|
|
|||
| const _attributesToInclude = [ | |||
Collaborator
There was a problem hiding this comment.
Style note: in dcmjs we avoid putting hex in the source code. Can you replace these with tokens from the metadata dictionary and convert them on the fly.
Author
There was a problem hiding this comment.
Hi, just wanted to clarify what you are referring to when you say token. For example on the first entry in the dictionary.js, would it be "(0000,0002)" or "CommandGroupLength"?
Should I also make this change for src/sr/documents.js?
Thanks,
-dxlin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start for RTSS support, add derivations, adapter, and updated dictionary. Requires relevant support from cornerstone3D (also WIP).