Skip to content

fix: images with color pallet lut not displaying properly#251

Open
ladeirarodolfo wants to merge 1 commit intodcmjs-org:masterfrom
ladeirarodolfo:hotfix/color-pallet-lut-black
Open

fix: images with color pallet lut not displaying properly#251
ladeirarodolfo wants to merge 1 commit intodcmjs-org:masterfrom
ladeirarodolfo:hotfix/color-pallet-lut-black

Conversation

@ladeirarodolfo
Copy link
Copy Markdown
Contributor

@ladeirarodolfo ladeirarodolfo commented Mar 7, 2022

Includes:

  • When naturilazing dataset prevent adding accessors to TypedArray/ArrayBuffer types

wayfarer3130
wayfarer3130 reviewed Mar 7, 2022
View reviewed changes
Comment thread src/DicomMetaDictionary.js
sqZero &&
typeof sqZero === "object" &&
!sqZero.length
!sqZero.length &&
Copy link
Copy Markdown
Contributor

@wayfarer3130 wayfarer3130 Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use Array.isArray to check if the value is an array.

@pieper pieper mentioned this pull request Mar 7, 2022
Open
@wayfarer3130
Copy link
Copy Markdown
Contributor

wayfarer3130 commented Mar 7, 2022

Please just use Array.isArray, drop the two extra files, and add a unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wayfarer3130 wayfarer3130 wayfarer3130 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ladeirarodolfo @wayfarer3130