phase-M M51: apply generic-scrape tokens before Name tokens#168
Merged
Conversation
proto's candidate is "xproto-7.0.31"; with Name="proto" the Name-token step stripped the bare "proto" inside "xproto-" -> "x-7.0.31", which the no-alpha filter then dropped (and the M42 "xproto-" token ran too late). PS adds these prefix tokens to $replace BEFORE the Name tokens, so it strips "xproto-" first. Reordered apply_generic_scrape_tokens to run before apply_name_replace_augmentations. Verified locally: proto now emits PS's exact warning (7.7 > 7.0.31); grub2/freetype2/xorg-fonts unaffected (their tokens don't collide with the Name). FRD: FRD-011 ADR: ADR-0001 PS-source: photonos-package-report.ps1 L 3346 vs L 4193-4196 Parity: strict Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proto candidate 'xproto-7.0.31' + Name='proto' → Name-token strips the 'proto' in 'xproto-' → 'x-7.0.31' → dropped on 'x'. PS strips 'xproto-' first ( order). Reordered apply_generic_scrape_tokens before apply_name_replace_augmentations. Verified locally: proto = PS warning (7.7>7.0.31); grub2/freetype2/xorg-fonts unaffected. build+ctest green.
FRD: FRD-011 · ADR: ADR-0001 · PS-source: L3346 vs L4193 · Parity: strict
🤖 Generated with Claude Code