phase-M M48: keep amdvlk quarterly versions (skip no-alpha filter)#164
Merged
Conversation
amdvlk tags are quarterly "YYYY.Q#.#" (e.g. 2025.Q2.1). The version comparator already orders them (version.c Case 2b), but the M21 no-alpha post-filter dropped every Q-tag on the "Q", leaving an older non-Q tag (2018.4.2) as the wrong latest. PS skips that filter for amdvlk (L2569 `if spec -notlike amdvlk`). Gated the apply_name_post_filters call on !amdvlk in the gitSource/tag path. Verified locally ROW-IDENTICAL to PS (col5=2025.Q2.1, col6, col9 SHA, col10). Low blast radius — gated to amdvlk; the shared comparator is unchanged. FRD: FRD-011 ADR: ADR-0001 PS-source: photonos-package-report.ps1 L 2569-2574 Parity: strict Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amdvlk tags are quarterly YYYY.Q#.# (2025.Q2.1). The comparator already orders them (version.c Case 2b), but the no-alpha post-filter dropped them on the 'Q' → C picked an older non-Q tag (2018.4.2). PS skips that filter for amdvlk (L2569). Gated apply_name_post_filters on !amdvlk. Verified locally ROW-IDENTICAL to PS incl col9 SHA. Low blast radius (gated; shared comparator unchanged). build+ctest green.
FRD: FRD-011 · ADR: ADR-0001 · PS-source: L2569-2574 · Parity: strict
🤖 Generated with Claude Code