Moves the calls to warn-when-not-reactive to the functions users are directly calling.#813
Open
green-coder wants to merge 1 commit intoday8:masterfrom
Open
Moves the calls to warn-when-not-reactive to the functions users are directly calling.#813green-coder wants to merge 1 commit intoday8:masterfrom
warn-when-not-reactive to the functions users are directly calling.#813green-coder wants to merge 1 commit intoday8:masterfrom
Conversation
…e directly calling.
kimo-k
force-pushed
the
master
branch
7 times, most recently
from
4b3c142 to
a9d7e79
Compare
kimo-k
force-pushed
the
master
branch
3 times, most recently
from
9b2dee6 to
492838f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of the change is to help users getting rid of false positive warnings, which in the browser console can hinder the discovery of other warnings that may happen during the normal development process of a re-frame app.