Add process.platform restriction to prevent install on incompatible p…#21
Open
babignano wants to merge 1 commit intodavidtsai:masterfrom
Open
Add process.platform restriction to prevent install on incompatible p…#21babignano wants to merge 1 commit intodavidtsai:masterfrom
babignano wants to merge 1 commit intodavidtsai:masterfrom
Conversation
Owner
|
This use to compile and work on windows. Preferably we fix the windows problems rather that disabling it if anyone with a windows machine wants to take a crack :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…latforms.
We've been having an issue where our production systems are on linux, some of the team development Mac OSX and some on Windows PCs. This module has issues installing and working on Windows machines so we get errors when trying to npm install. We can't set it as an optional dependecy as it's needed for production.
This flag will prevent the module from being installed where it should