Merged
Conversation
Load contacts from ~/.config/ringo/contacts.toml with name → numbers mapping. Resolve contact names in call list and call history. Add contacts picker overlay (f key) with search, navigation, and $EDITOR integration for editing contacts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use the same pattern as edit_profile: set a flag, break out of render_loop, open $EDITOR via terminal.backend_mut(), then terminal.clear() and resume. Removes the needs_clear workaround. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- [a] add new contact via inline form (name + comma-separated numbers) - [e] edit selected contact inline - [d] delete selected contact - [E] open $EDITOR (moved from [e]) - Tab switches between name/numbers fields, Enter saves, Esc cancels - save() in contacts.rs writes Vec<Contact> back to TOML Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add confirmation prompt (y/n) before deleting contacts, and implement fuzzy number matching so contacts saved in different formats (local 01555..., international +491555..., no-plus 491555...) resolve correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
davidborzek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.config/ringo/contacts.toml(name → numbers mapping)fkey /:contactscommand) with fuzzy search, navigation, and Enter to dialaadd,eedit,ddelete (with y/n confirmation)$EDITOR(Ein picker) with auto-reload — uses render_loop-level terminal handoff01555...resolve for calls from+491555...,491555...,004915551...and vice versaTest plan
cargo test— all 124 tests pass (18 new for contacts module)~/.config/ringo/contacts.toml→f→ contacts visibleaadd contact → form popup → Tab switch fields → Enter saveseedit contact → pre-filled form → modify → Enter savesddelete contact → confirmation prompt →ydeletes, any other key cancelsEin contacts picker → editor opens → changes reload on close+49...matches contact saved as0...(and vice versa)🤖 Generated with Claude Code