feat(hello): use path-based profile URLs for modal deep links#1341
Merged
Conversation
Contributor
🔎 SEO & Meta ReviewSkipped (mode: No |
Replace hash deep links (/hello/#slug) with shareable paths (/hello/slug) while keeping the popup on a single /hello page via client History API and server rewrites in middleware and server.mjs.
AriaEdo
approved these changes
May 25, 2026
felixwidjaja
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/hello/#scott) with shareable path URLs (/hello/scott) while keeping the popup UX on a single/hellopageserver.mjs(production) andsrc/middleware.ts(dev) so direct visits to/hello/:slugrender the same/helloSSR page without a new Astro route per profileHelloModalandHelloPeoplefor open/close/back navigation, legacy hash migration, and invalid slug handlingHow it works
pushState→/hello/scott, modal opens (no server request)/hellopopstatecloses the modal/hello/scottloads/hellovia rewrite, client opens modal from pathname/hello/#scottmigrates once to/hello/scottTest plan
/hello, click a profile card → URL becomes/hello/:slug, modal opens/hello/hello/hello/:slug→ page loads, modal auto-opens/hello/invalid-slug→ grid visible, no modal, URL normalized to/hello/hello/#:slug→ client migrates to/hello/:slug, modal opens