chore: remove unused react-day-picker dependency#1255
Closed
kevwilliams wants to merge 1 commit into
Closed
Conversation
react-day-picker is declared in package.json but has no imports anywhere in the codebase. Drop it to shrink the dependency surface and close out the v10 major-bump Renovate PR as unneeded.
🧪 Test Summary
📎 ArtifactsNo artifacts (all tests passed). |
Contributor
|
@kevwilliams is it needed by datum-ui? |
Contributor
Author
|
Yea - https://github.com/datum-cloud/datum-ui/blob/main/packages/datum-ui/package.json#L442 - We should get renovate setup on that repo |
Contributor
|
@kevwilliams This package is a peer dependency for the date picker component of datum-ui. https://github.com/datum-cloud/datum-ui/blob/main/packages/datum-ui/package.json#L533-L534 |
Contributor
Author
|
Right, yea we can close this but I do think we should add renovate to datum-ui which would keep this in sync for us I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-day-pickeris declared inpackage.jsonbut has zero imports across the codebase (grep -rn react-day-picker app/returns nothing; noDayPickerusages either).Test plan
bun installcleanly updatesbun.lockbun run typecheckpassesbun run buildpassesCloses #1242