feat: connection groups with multi-selection and hierarchical management by imhuytq · Pull Request #140 · datlechin/TablePro

imhuytq · 2026-03-02T09:26:04Z

Summary

Adds a hierarchical connection groups system to the welcome window, letting users organize database connections into named, color-coded folders with arbitrary nesting depth.

Core features

Hierarchical groups: create nested folders with color-coded icons to organize connections
NSOutlineView: replaces SwiftUI List with NSOutlineView for native tree view, expand/collapse, and drag-and-drop
Multi-selection: select multiple connections for bulk delete, bulk move to group, and multi-drag into groups
Drag-and-drop: reorder connections and groups within/across groups, move connections between groups (single and multi), with position-aware drop
Keyboard shortcuts: Backspace to delete selected items, Return to connect/toggle
2-step delete confirmation: deleting a group with connections requires two confirmations to prevent accidental data loss
Expand/collapse persistence: group expanded state persists across app launches
Context menus: full context menu support for groups (new subgroup, edit, delete) and connections (connect, edit, duplicate, copy URL, move to group, delete)

Data model changes

ConnectionGroup: new model with parentGroupId for nesting, sortOrder, and color
DatabaseConnection.sortOrder: new field for stable ordering within groups
GroupStorage: CRUD, hierarchy helpers, expanded state persistence, descendant deletion with connection cleanup
Legacy migration: auto-assigns sequential sortOrder when upgrading from older versions without ordering

Storage behavior

Deleting a group deletes all connections inside (not ungroup)
ConnectionStorage.duplicateConnection preserves all fields and inserts right after the original
ConnectionFormView preserves sortOrder when editing existing connections

UI/UX details

Selection managed natively by NSOutlineView (no SwiftUI state overhead)
Scroll position and expanded state preserved across data reloads
Multi-group drag disabled (moving parent already moves children)
Empty state overlay allows context menu on empty list
Group form sheet loads groups once on appear (not on every recompute)

chatgpt-codex-connector · 2026-03-02T09:26:10Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

datlechin · 2026-03-02T12:27:30Z

Run bị lỗi rồi anh ơi

/Users/ngoquocdat/Projects/TablePro/TablePro/Models/DatabaseConnection.swift
/Users/ngoquocdat/Projects/TablePro/TablePro/Models/DatabaseConnection.swift:239:8 Type 'DatabaseConnection' does not conform to protocol 'Hashable'

/Users/ngoquocdat/Projects/TablePro/TablePro/Models/DatabaseConnection.swift:239:8 Type 'DatabaseConnection' does not conform to protocol 'Equatable'

/Users/ngoquocdat/Projects/TablePro/TablePro/Models/DatabaseConnection.swift:256:9 Invalid redeclaration of 'groupId'

/Users/ngoquocdat/Projects/TablePro/TablePro/Models/DatabaseConnection.swift:276:9 Invalid redeclaration of 'groupId'

/Users/ngoquocdat/Projects/TablePro/TablePro/Models/DatabaseConnection.swift:313:1 Type 'DatabaseConnection' does not conform to protocol 'Decodable'

/Users/ngoquocdat/Projects/TablePro/TablePro/Models/DatabaseConnection.swift:313:1 Type 'DatabaseConnection' does not conform to protocol 'Encodable'

# Conflicts: # TablePro/Models/DatabaseConnection.swift # TablePro/Views/WelcomeWindowView.swift

…search filter and keychain threading

imhuytq · 2026-03-04T19:08:40Z

@datlechin please review

Copilot

Pull request overview

Adds a hierarchical “connection groups” feature to the welcome window, enabling nested folders for organizing database connections with expand/collapse persistence and drag-and-drop reordering.

Changes:

Replaces the SwiftUI List connection list with an NSOutlineView-backed tree view that supports nesting, drag/drop, and context menus.
Introduces a reusable group create/edit sheet and updates group pickers to support nested group selection.
Extends storage/models to support group hierarchy (parentGroupId), ordering (sortOrder), and persisted expanded state.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
TablePro/Views/WelcomeWindowView.swift	Integrates group CRUD + expand state and swaps in the outline-based connection list.
TablePro/Views/WelcomeWindow/ConnectionOutlineView.swift	New `NSOutlineView` wrapper implementing hierarchy rendering, drag/drop reorder, and context menus.
TablePro/Views/Connection/ConnectionGroupPicker.swift	Updates the connection-form group picker to render nested groups and adds group management actions.
TablePro/Views/Connection/ConnectionGroupFormSheet.swift	New create/edit group sheet with color and parent-group selection (cycle prevention).
TablePro/Views/Connection/ConnectionFormView.swift	Minor update to reflect group support in form state (comment only in this diff).
TablePro/Resources/Localizable.xcstrings	Adds/removes localization keys used by new group UI.
TablePro/Models/DatabaseConnection.swift	Adds `sortOrder` to support stable ordering/reordering.
TablePro/Models/ConnectionGroup.swift	Adds hierarchy + ordering fields and migration-aware decoding.
TablePro/Core/Storage/GroupStorage.swift	Adds hierarchy helpers, expanded-state persistence, and descendant deletion behavior.
TablePro/Core/Storage/ConnectionStorage.swift	Persists `sortOrder` with migration fallback for pre-existing connections.
CHANGELOG.md	Documents the new “Connection groups” feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TablePro/Models/DatabaseConnection.swift

TablePro/Views/WelcomeWindow/ConnectionOutlineView.swift

TablePro/Views/WelcomeWindowView.swift

TablePro/Core/Storage/GroupStorage.swift

TablePro/Views/WelcomeWindow/ConnectionOutlineView.swift

TablePro/Views/Connection/ConnectionGroupFormSheet.swift

TablePro/Views/WelcomeWindowView.swift

…ovements

datlechin · 2026-03-06T05:45:55Z

@imhuytq fix conflict lun nha a :d

imhuytq · 2026-03-06T06:11:55Z

@datlechin review giúp với

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TablePro/Views/WelcomeWindowView.swift

TablePro/Views/WelcomeWindow/ConnectionOutlineView.swift

TablePro/Core/Storage/GroupStorage.swift

TablePro/Views/WelcomeWindowView.swift

TablePro/Views/WelcomeWindow/ConnectionOutlineView.swift

TablePro/Core/Storage/ConnectionStorage.swift

TablePro/Views/Connection/ConnectionGroupFormSheet.swift

TablePro/Models/ConnectionGroup.swift

- GroupStorage.addGroup returns Bool; duplicate check scoped to siblings - ConnectionGroupPicker delete now requires confirmation dialog - acceptGroupDrop adjusts childIndex for mixed group/connection children - isDragging set only after validation passes in drag source - totalConnectionCount guards against circular parentGroupId cycles - duplicateConnection returns placed copy with correct sortOrder - 2-step delete step2 only shown for group-resident connections - Remove duplicated collectDescendantIds; reuse GroupStorage method - Remove unnecessary comments in WelcomeWindowView

…rm sheet perf

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TablePro/Views/WelcomeWindow/ConnectionOutlineView.swift

TablePro/Views/Connection/ConnectionGroupPicker.swift

docs/download.mdx

docs/vi/download.mdx

TablePro/Views/WelcomeWindowView.swift

datlechin · 2026-03-06T12:45:37Z

Em chạy lên thấy màu active hình như bị nhạt hơn so với bình thường

imhuytq added 3 commits March 2, 2026 18:32

feat: add connection groups

3ff40ec

update

4c5d8e2

chore: update localization strings

e00e14e

imhuytq force-pushed the feat/connection-groups branch from c3497e9 to e00e14e Compare March 2, 2026 11:34

imhuytq added 5 commits March 5, 2026 00:20

fix

7aab5b9

Merge branch 'main' into feat/connection-groups

1f961ca

# Conflicts: # TablePro/Models/DatabaseConnection.swift # TablePro/Views/WelcomeWindowView.swift

feat: support nested group selection in form sheet and context menus

1af3852

docs: add connection groups to changelog

f7ef8ce

refactor: rename ConnectionGroupEditor to ConnectionGroupPicker, fix …

2fd698b

…search filter and keychain threading

datlechin requested a review from Copilot March 5, 2026 02:23

datlechin self-assigned this Mar 5, 2026

Copilot started reviewing on behalf of datlechin March 5, 2026 02:23 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

imhuytq added 2 commits March 6, 2026 10:34

fix: address Copilot PR review comments and add backspace delete support

b76144f

feat: multi-selection, 2-step delete confirmation, and drag-drop impr…

2d2bfb7

…ovements

imhuytq and others added 5 commits March 6, 2026 12:48

Merge branch 'main' into feat/connection-groups

6c797af

docs: add dedicated download page with direct DMG links

1e9bb1d

fix: reset pbxproj to main and regenerate Localizable.xcstrings

334b5fa

Merge branch 'main' into feat/connection-groups

185d2af

fix: regenerate Localizable.xcstrings after merge

deb5c35

imhuytq requested a review from Copilot March 6, 2026 06:07

Copilot started reviewing on behalf of imhuytq March 6, 2026 06:08 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

datlechin and others added 2 commits March 6, 2026 13:28

fix: sortOrder migration for legacy data, multi-drag position, and fo…

f96489f

…rm sheet perf

imhuytq changed the title ~~feat: add connection groups~~ feat: connection groups with multi-selection and hierarchical management Mar 6, 2026

fix: group drag-drop position when reordering after last group

864f32a

imhuytq requested a review from Copilot March 6, 2026 06:52

Copilot started reviewing on behalf of imhuytq March 6, 2026 06:53 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

datlechin force-pushed the feat/connection-groups branch from 5620545 to 864f32a Compare March 6, 2026 08:14

fix: correct drag-drop reorder position when moving items forward

bd1effe

Uh oh!

Conversation

imhuytq commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Core features

Data model changes

Storage behavior

UI/UX details

Uh oh!

chatgpt-codex-connector bot commented Mar 2, 2026

Uh oh!

datlechin commented Mar 2, 2026

Uh oh!

imhuytq commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

datlechin commented Mar 6, 2026

Uh oh!

imhuytq commented Mar 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

datlechin commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

imhuytq commented Mar 2, 2026 •

edited

Loading