Fix up naming of order metrics#446
Merged
nblumhardt merged 2 commits intodatalust:devfrom Feb 23, 2026
Merged
Conversation
nblumhardt
approved these changes
Feb 23, 2026
Member
nblumhardt
left a comment
nblumhardt
left a comment
There was a problem hiding this comment.
Build failure is an unrelated one that I guess must have slipped through while our Windows integration test runs were flaky:
Either the
delete-all-eventsordeleteoptions must be specified
I'll take a look separately 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes up a lingering data issue with the pre-release metrics generated by
sample ingestwhere the definitions and values don't line up. I've refactored it slightly to make this less likely in the future. We don't really need that extra layer of spread for metric samples, since they're just regular properties anyways, it's only the definitions that are a bit special.