Dockerize proteogram repo, mounting input datasets as a volume#3
Open
swapnilashtekar wants to merge 3 commits intomd-sim-and-docsfrom
Open
Dockerize proteogram repo, mounting input datasets as a volume#3swapnilashtekar wants to merge 3 commits intomd-sim-and-docsfrom
swapnilashtekar wants to merge 3 commits intomd-sim-and-docsfrom
Conversation
swapnilashtekar
force-pushed
the
uvAndDockerize2
branch
from
bd35688 to
3ff0663
Compare
datagato
reviewed
Mar 1, 2026
datagato
reviewed
Mar 1, 2026
datagato
reviewed
Mar 1, 2026
| This repo is dockerized to run scripts under `/scripts` (e.g. measure_similarity.py, create_proteograms.py etc.) | ||
|
|
||
| ## Prerequisites | ||
| - Docker installed |
Owner
There was a problem hiding this comment.
Should we indicate what platforms this has been tested on?
Collaborator
Author
There was a problem hiding this comment.
Yes, added below platforms for now irrespective of GPU. Let me know if you have any additional platforms that we can test this on.
linux/amd64 or linux/arm64
datagato
reviewed
Mar 1, 2026
datagato
reviewed
Mar 1, 2026
Owner
|
Hi @swapnilashtekar! Thank you so much for pushing this important contribution for reproducibility and package management. I have added a few comments, but overall this is very good and helpful to the project. Happy to discuss more and welcome further contributions you can make. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker guide (uv-based)